Unmet hours for dehumidification#2217
Open
shorowit wants to merge 15 commits into
Open
Conversation
shorowit
commented
May 12, 2026
…HPXML into dehumid_unmet_hours # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml # workflow/tests/base_results/results_simulations_misc.csv
Contributor
There was a problem hiding this comment.
Pull request overview
Adds annual/timeseries reporting support for dehumidification unmet hours, addressing #2203 by calculating hours where RH exceeds the dehumidifier setpoint tolerance and surfacing warnings for large values.
Changes:
- Adds dehumidification unmet-hours EMS generation and reporting plumbing.
- Adds dehumidifier availability EMS sensor support.
- Updates constants, tests, measure metadata, README, docs, and changelog for the new output.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
ReportSimulationOutput/tests/test_report_sim_output.rb |
Adds dehumidification unmet-hours columns to expected report outputs. |
ReportSimulationOutput/README.md |
Documents the new measure output name. |
ReportSimulationOutput/measure.xml |
Registers the new output and updates checksums/version metadata. |
ReportSimulationOutput/measure.rb |
Wires dehumidification unmet hours into EMS output requests, annual reporting, and warnings. |
HPXMLtoOpenStudio/resources/output.rb |
Adds EMS program for dehumidification unmet hours and renames/refactors unmet-hours program constants/variables. |
HPXMLtoOpenStudio/resources/hvac.rb |
Adds an EMS sensor for dehumidifier availability schedules. |
HPXMLtoOpenStudio/resources/constants.rb |
Adds dehumidification unmet-hours and availability constants. |
HPXMLtoOpenStudio/measure.xml |
Updates resource checksums/version metadata. |
docs/source/workflow_outputs.rst |
Documents dehumidification unmet-hours behavior and warning threshold. |
Changelog.md |
Notes the new dehumidification unmet-hours feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…HPXML into dehumid_unmet_hours # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_misc.csv
…HPXML into dehumid_unmet_hours # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml # workflow/tests/base_results/results_simulations_misc.csv
Contributor
Author
|
Filed an EnergyPlus issue: NatLabRockies/EnergyPlus#11657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #2203. Adds a dehumidification unmet hours output (tolerance = 1% RH) as well as a warning if the number of hours exceeds 300. If there are no dehumidifiers, zero will be reported.
Note: E+ with hourly timesteps does not perfectly maintain RH setpoint, rather we see oscillations that can result in reported unmet hours. Is this something we can address?
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run