fixed endless SOC iteration for HEVs#260
Merged
Merged
Conversation
Collaborator
Author
|
Worth noting too that the default maximum iterations in fastsim-3 is @jakeholden Should we change this limit back? |
…all `.clone()` where `T: Copy`
Collaborator
Author
|
@jhoshiko the error for > 5 iterations seems like its pretty vague, let me know if the message you see should be changed :) fastsim/fastsim-core/src/simdrive/mod.rs Lines 176 to 204 in e05cacf |
# Conflicts: # pixi.lock
Collaborator
Author
|
@jhoshiko can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jhoshiko @jakeholden
I've fixed the issue with endless SOC iteration that we were seeing in https://github.nrel.gov/MBAP/fastsim/issues/423.
The issue was that when starting a new iteration, only the ending SOC -> starting SOC carryover was plumbed up correctly. The actual iteration counter was getting reset each iteration as it is stored within the Vehicle object.
This PR does not fix the issues with those specific vehicles not converging to a balanced SOC!