Use FLORIS's methods for merging fmodels and setting model parameters#182
Merged
Conversation
7 tasks
This was referenced Apr 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
merge_floris_objectsmethod was moved tomerge_floris_modelson FLORIS, and setting wake model parameters was made easier in FLORIS.Similar to #181, this PR removes FLASC's now duplicate capability and uses FLORIS's instead. We also remove the function
reduce_floris_object, as this seems unneeded---users may simply choose a set of indices and use theFlorisModel.set()method, passing (new) keywords forlayout_x,layout_y, andturbine_type.For now, I am testing FLORIS's merging capabilities within the FLASC tests, essentially. This test may be moved to FLORIS at a later date.