Change NREL to NLR#492
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release_321 #492 +/- ##
==============================================
Coverage ? 96.86%
==============================================
Files ? 12
Lines ? 2332
Branches ? 0
==============================================
Hits ? 2259
Misses ? 73
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@martin-springer because we are having a bit of a discussion on this in pvlib, is rdtools keeping e.g. "NREL TMY3", "NREL SPA" or are these being renamed to NLR? |
@cwhanse - good question. I've only left one reference to NREL (for now) in rdtools and that is for a PVDAQ dataset that used an NREL site and was previously published. I wanted to get @mdeceglie opinion, before making the change to NLR for that reference. Looking at this webpage https://midcdmz.nrel.gov/spa/ it seems like NREL SPA got already renamed into NLR SPA. I think, over the long run, we'll be replacing NREL entirely with NLR - especially since the nrel.gov domain will go away rather soon. |
|
Thanks for helping to calibrate our thinking. We (pvlib maintainers) are inclined to leave "NREL" in bibliographic information, e.g., NREL Technical Report, since the report lists "NREL" as the publisher and changing to "NLR Technical Report" risks future "typo" issues. We're divided on the renaming of "NREL SPA". |
Changelog v3.2.1.rst: - Correct PR references: :pull:`488` -> :pull:`491` for the pyproject migration; :pull:`492` -> :pull:`493` for pixi adoption and related entries (NREL->NLR entry kept at #492); :pull:`494` -> :pull:`497` for the filterpy replacement (landed as direct commits on release_321). - Remove duplicated arch/xgboost/pvlib minimum-version bumps already documented in v3.1.1.rst. Documentation: - Remove duplicate git clone line in developer_notes.rst. - Remove duplicate sentence in index.rst. - Revert historical rewrite `NLR's` -> `NREL's` South Table Mountain campus in v2.0.0.rst (STM is NREL's campus and v2.0.0 predates the NLR migration). Example notebooks: - `pixi run -e notebooks lab` -> `pixi run lab` in all five example notebooks; there is no `notebooks` environment defined in pyproject.toml (only a `notebooks` feature, which the default environment already includes). Repository hygiene: - Remove committed developer-local `.pixi.lnk` Windows shortcut. - Add `*.lnk` to `.gitignore` to prevent future accidental commits of machine-specific shortcut files.
Update GitHub URLs and references from NREL to NatLabRockies
Updates all GitHub URLs from
NREL/rdtoolstoNatLabRockies/rdtoolsand email addresses from@nrel.govto@nlr.govacross the repository. Also updates the org name reference from "NREL" to "NLR" in comments and changelogs. Dataset proper names (e.g.,NREL PVDAQ) and GitHub usernames (e.g.,kanderso-nrel) are left unchanged.Files changed
pyproject.toml— project URLsREADME.md— badges, citation, and wiki linkCITATION.cff— repository URLCODE_OF_CONDUCT.md— contact emailrdtools/soiling.py— issue links in warningsrdtools/test/soiling_test.py— issue link in docstringrdtools/test/filtering_test.py— location commentdocs/sphinx/source/conf.py— extlinks and source URLdocs/sphinx/source/index.rst— citation and link targetsdocs/sphinx/source/developer_notes.rst— clone URLdocs/sphinx/source/changelog/v2.0.0.rst— campus namedocs/sphinx/source/changelog/pending.rst— changelog entryCloses
Checklist
__init__.py