[schemas] Fix typed-reasoning-edges COMMENT ON syntax error#303
Conversation
The COMMENT ON FUNCTION statement for thought_edges_upsert used the SQL || concatenation operator to join three string literals. PostgreSQL's COMMENT statement requires a single string literal after IS, not an expression, so the migration fails with a syntax error at the first ||. Collapse the three pieces into one literal so the schema applies cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hey @lucifer — welcome to Open Brain Source! 👋 Thanks for submitting your first PR. The automated review will run shortly and check things like metadata, folder structure, and README completeness. If anything needs fixing, the review comment will tell you exactly what. Once the automated checks pass, a human admin will review for quality and clarity. Expect a response within a few days. If you have questions, check out CONTRIBUTING.md or open an issue. |
|
Have we stalled? This should be a strightforward pass |
|
Thanks for the contribution. Confirmed the fix: PostgreSQL's One note for the maintainer: #227 makes the same fix to the same lines of — Alan (community reviewer; non-binding) |
justfinethanku
left a comment
There was a problem hiding this comment.
Maintainer pass complete. Verified this is a surgical SQL syntax fix to the existing COMMENT ON FUNCTION ... IS string literal, refreshed the branch against current main, and confirmed there are no unresolved review threads to carry forward.
Contribution Type
/schemas)What does this do?
Fixes a syntax error in
schemas/typed-reasoning-edges/schema.sqlthat prevents the migration from running. TheCOMMENT ON FUNCTION public.thought_edges_upsert IS ...statement uses the SQL||concatenation operator to join three string literals, but PostgreSQL'sCOMMENTstatement requires a single string literal afterIS, not an expression. Pasting the script into the Supabase SQL editor fails with:Collapsing the three pieces into one literal lets the schema apply cleanly. No behavior change — same comment text.
Requirements
None beyond what
schemas/typed-reasoning-edges/already lists.Checklist
Test plan
schemas/typed-reasoning-edges/schema.sqlfrom this branch in Supabase SQL editor against a brain that already hasschemas/entity-extraction/appliedthought_edgestable exists, the temporal columns onedgesexist, andSELECT obj_description('public.thought_edges_upsert'::regproc);returns the expected comment🤖 Generated with Claude Code