[codex] Fix OB1 gate empty workflow runs#323
Draft
justfinethanku wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targetso conflicted PRs can still produce real gate results instead of zero-job failurespull_request_targetsafer by using read-only permissions and validating metadata against the base-branch schemaRoot Cause
GitHub was creating
.github/workflows/ob1-gate.ymlruns with zero jobs. Recent evidence showed push events onmainplus PR force-push/conflict cleanup. GitHub documents thatpull_requestworkflows do not run when a PR has merge conflicts, which matches the noisy PR examples.Validation
ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "parsed #{f}" }' .github/workflows/ob1-gate.yml .github/workflows/ob1-pr-followups.yml\n-git diff --check\n-npx --yes node-actionlint .github/workflows/ob1-gate.yml .github/workflows/ob1-pr-followups.yml\n- live manual run on this branch: https://github.com/NateBJones-Projects/OB1/actions/runs/26184769762 (OB1 Gate Event Guardran successfully;OB1 Reviewskipped as intended forworkflow_dispatch)\n\n## Note\nThe changedpull_request_targetworkflow will only become active for PR events after this lands onmain, because GitHub evaluatespull_request_targetworkflows from the default branch.