[schemas] Document workflow-status prerequisite for enhanced-thoughts#328
Draft
drewyd wants to merge 1 commit into
Draft
[schemas] Document workflow-status prerequisite for enhanced-thoughts#328drewyd wants to merge 1 commit into
drewyd wants to merge 1 commit into
Conversation
The enhanced-thoughts schema's upsert_thought function writes to the status and status_updated_at columns on the thoughts table (schema.sql lines 347-383), but those columns are created by the workflow-status schema. Applying enhanced-thoughts on a fresh install without first applying workflow-status fails with: column "status" of relation "thoughts" does not exist Adds a clearly placed Prerequisites callout near the top of the enhanced-thoughts README pointing to the workflow-status schema as a hard dependency. No code or SQL changes — docs only. Caught during a 5-schema install on 2026-05-26. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hey @drewyd — welcome to Open Brain Source! 👋 Thanks for submitting your first PR. The automated review will run shortly and check things like metadata, folder structure, and README completeness. If anything needs fixing, the review comment will tell you exactly what. Once the automated checks pass, a human admin will review for quality and clarity. Expect a response within a few days. If you have questions, check out CONTRIBUTING.md or open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
enhanced-thoughtsschema has a hidden dependency on theworkflow-statusschema that isn't documented in the README. This PR adds a clearly placed Prerequisites callout.Symptom (fresh install)
Running
schemas/enhanced-thoughts/schema.sqlon a project that hasn't appliedworkflow-statusfirst fails with:The failure happens inside the
CREATE OR REPLACE FUNCTION public.upsert_thoughtblock.Why
schemas/enhanced-thoughts/schema.sqlwrites to two columns on thethoughtstable thatenhanced-thoughtsdoes not itself create:statusandstatus_updated_atThose columns are created by
schemas/workflow-status/(see its README and migration).Fix
Single doc-only change to
schemas/enhanced-thoughts/README.md: adds an> [!IMPORTANT]callout at the top of the existing Prerequisites section, plus a new bullet linking to../workflow-status/. No SQL, code, ormetadata.jsonchanges.File changes
schemas/enhanced-thoughts/README.md(+4 lines, -0)Test plan
workflow-statusfirst, thenenhanced-thoughts— both succeedenhanced-thoughtsdirectly — reproduces thecolumn "status" does not existerror referenced in the README callout../workflow-status/resolves on github.comCaught while installing five schemas during a Brain Architecture build on 2026-05-26.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com