[dashboards] Link wiki evidence chips to thought pages#408
[dashboards] Link wiki evidence chips to thought pages#408alanshurafa wants to merge 11 commits into
Conversation
The integration was ported from a bigint-id codebase and parsed thought and job ids as numbers. On Open Brain (UUID primary keys) that breaks at runtime: upsert_thought returns a UUID that extractThoughtId rejects as "no thought_id", /execute 400s on a UUID job_id, and the pro dashboard's ingest routes reject every UUID with a positive-integer guard. Convert every ingestion id field (integration + both dashboards) from number to string, validate job ids as UUIDs, and replace the 0 "no id" sentinel with an empty string. Pairs with the smart-ingest-tables schema so a job completes end to end on a fresh UUID install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Post-UUID conversion, the integer job_id examples return 400 ("must be a UUID"). Align the docs with the handler's UUID_RE check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
dashboard
OB1 PR Gate✅ Folder structure — All files are in allowed directories Result: All 15 checks passed! Ready for human review. Post-Merge TasksThese don't block merge — they're reminders for admins after this PR lands.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39d3bde4cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| label: "typed-reasoning-edges (thought_edges; needs entity edges)", | ||
| }, | ||
| wikiPages: { | ||
| file: "schemas/wiki-pages/schema.sql", |
There was a problem hiding this comment.
The default wiki-crm bundle includes wikiPages, so readSchemaSql immediately tries to read schemas/wiki-pages/schema.sql; that file is not present in this checkout, and the same is true for the CRM schema paths referenced just below (schemas/crm-core and schemas/crm-engagement). As a result the advertised one-command installer exits with Schema file not found before applying any SQL unless the user manually switches to --bundle core.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| const meta = person.metadata || {}; | ||
| const contact = await gateway("POST", "/crm/contacts", { |
There was a problem hiding this comment.
The default --demo path posts to /crm/contacts, but the checked-in integrations/open-brain-rest gateway this recipe tells users to deploy does not define any /crm/* routes (repo-wide search of that integration finds none). After the initial /health succeeds, the first contact creation therefore returns 404 and the quick-start cannot demonstrate the CRM flow.
Useful? React with 👍 / 👎.
| const jobId = typeof body.job_id === "string" && UUID_RE.test(body.job_id.trim()) | ||
| ? body.job_id.trim() | ||
| : ""; |
There was a problem hiding this comment.
This new UUID-only check rejects the job IDs produced by the current smart-ingest schema: schemas/smart-ingest/schema.sql still declares ingestion_jobs.id bigserial, and the REST proxy path for job execution is numeric. Any dry-run job created by the existing tables is sent back as a numeric ID, so /smart-ingest/execute now returns job_id is required (must be a UUID) instead of executing it.
Useful? React with 👍 / 👎.
alanshurafa
force-pushed
the
upstream/dash-evidence-links
branch
from
39d3bde to
50640bd
Compare
alanshurafa
force-pushed
the
upstream/dash-evidence-links
branch
from
50640bd to
bf929f1
Compare
1 participant
Links UUID-shaped wiki evidence chips to their
/thoughts/{id}pages inopen-brain-dashboard-pro.Depends on #407 (stacked; diff includes ancestors until they merge).