themes: only enqueue MMCE decorator art on selection transitions#30
Merged
NathanNeurotic merged 1 commit intoMay 1, 2026
Merged
Conversation
Separate MMCE items-list decorator cover request initiation from draw-time retrieval. Track selected submenu item ID + startup string in items list state, and only call cacheGetTexture on actual selection changes. Keep draw path display-only via cacheGetTextureIfReady when selection is unchanged. Non-MMCE modes retain existing behavior.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
items_list_tininclude/themes.haslastSelectedItemIdandlastSelectedStartup[256]to detect selection transitions.src/themes.cdrawItemsListcomputemmceSelectionChangedwhenlist->mode == MMCE_MODEand the decorator has a cache by comparingitem->item.idand the startup string fromlist->itemGetStartup(list, item->item.id).getGameImageTexture/cacheGetTexture) only when the selection actually changed for the selected row, and otherwise usecacheGetTextureIfReadyfor display-only retrieval to avoid queuing IO from the draw path.initItemsListsolastSelectedItemIdstarts as-1andlastSelectedStartupis empty, and leave non-MMCE retrieval logic unchanged.Testing
make -j2(project build) which failed in this environment because required language YAML files are missing (lng_src/English.yml,lng_src/Albanian.yml), so a full build verification could not complete.make obj/themes.owhich failed due to no matching Makefile rule in this environment, so further compile validation was not possible here.Codex Task