Debounce MMCE interactive art enqueue and coalesce pending targets#31
Merged
NathanNeurotic merged 1 commit intoMay 1, 2026
Merged
Conversation
Add a short MMCE-only selection-change debounce window and tighten queue handling so interactive requests do not churn while an older MMCE title is still loading. Requests now collapse to the newest startup key, preventing repeated requeues each frame without altering existing texture release/displaced-texture cleanup behavior.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CACHE_MMCE_INTERACTIVE_DEBOUNCE) and tracking state (gMmceInteractiveDebounceUntilFrame,gMmceInteractiveDebounceValue) to delay enqueueing interactive MMCE requests for a few frames after a selection change, wired intocacheGetTextureInternalto gate interactive enqueue. (src/texcache.c)valueand drop queued MMCE requests for different values:cacheHasQueuedInteractiveMmceValueLocked,cacheDropQueuedInteractiveMmceDifferentValueLocked, andcacheShouldDebounceMmceInteractiveLocked. (src/texcache.c)src/texcache.c)cacheReleaseTexture, displaced texture handling, request cleanup/abort paths) unchanged. (src/texcache.c)cacheAbortMmceImageLoadsTimedusage; confirmed the notable callsite inmmceLaunchGameremains a transition-time abort and was not altered. (src/mmcesupport.c)Testing
make -j2, which failed in this environment due to missing generated language source files (lng_src/Albanian.yml,lng_src/English.yml), so a complete build/test could not be completed here. (failure)rg/sed/nlto verify inserted functions are called from the interactive enqueue flow and that existing request cleanup/abort paths remain intact. (inspection)Codex Task