Centralize platform/PS2SDK includes into platform_includes.h#80
Closed
NathanNeurotic wants to merge 5 commits into
Closed
Centralize platform/PS2SDK includes into platform_includes.h#80NathanNeurotic wants to merge 5 commits into
platform_includes.h#80NathanNeurotic wants to merge 5 commits into
Conversation
Codacy's Analysis Summary18 new issues (≤ 0 issue) Review Pull Request in Codacy →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cppcheckby guarding with#ifndef __CPPCHECK__so static analysis and PS2SDK builds behave correctly.PSX,HDD,FILEXIO,EE_SIO_DEBUG) so optional SDK headers remain visible only when intended.Description
include/platform_includes.hwhich lists standard C and PS2SDK headers and is wrapped in#ifndef __CPPCHECK__and include guards.#include <...>lines with#include "platform_includes.h"across sources and headers, keeping local/project headers and their ordering unchanged.#ifdef PSX,#if defined(HDD) || defined(HDD_RUNTIME),#ifdef FILEXIO,#ifdef EE_SIO_DEBUG) inside the shared header so behavior remains the same per-target.platform_includes.hwhere needed.Testing
rg "#include <" src include) to confirm system/SDK#include <...>occurrences were consolidated intoplatform_includes.h, and the search result shows only the new wrapper lines, indicating success.Add platform include wrapperand 24 files updated.Codex Task