Conversation
PeteBishwhip
requested changes
Mar 14, 2025
| "illuminate/contracts": "^10.0|^11.0|^12.0", | ||
| "laravel/prompts": "^0.1.1|^0.2|^0.3", | ||
| "nativephp/laravel": "^1.0-beta.2", | ||
| "nativephp/laravel": "dev-feat/bundle-builds", |
Member
There was a problem hiding this comment.
This needs reverting before merge
Member
Author
There was a problem hiding this comment.
Yes! It was on purpose so @simonhamp could test the PR.
If I have a PR with both repos, I often leave the dependency to help reviewers.
I don't know if it's a good way to do it or not. Feedback is welcome.
Member
There was a problem hiding this comment.
No worries! Just a message as a reminder is all! :)
simonhamp
reviewed
Mar 14, 2025
Member
simonhamp
left a comment
simonhamp
left a comment
There was a problem hiding this comment.
A few things just to tidy up, but both of these PRs are looking amazing. Well done!
Member
Author
|
Pushed changes based on your review, @simonhamp. |
simonhamp
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.