Skip to content

fix: App::version() not returning the correct version#208

Merged
simonhamp merged 2 commits intomainfrom
fix-app-version
Apr 7, 2025
Merged

fix: App::version() not returning the correct version#208
simonhamp merged 2 commits intomainfrom
fix-app-version

Conversation

@SRWieZ
Copy link
Copy Markdown
Member

@SRWieZ SRWieZ commented Apr 7, 2025

From electron code comment:

getVersion(): string; The version of the loaded application. If no version is found in the application's package.json file, the version of the current bundle or executable is returned.

@SRWieZ
Copy link
Copy Markdown
Member Author

SRWieZ commented Apr 7, 2025

Hmm, I think it still works in production.

But not with native:serve. Sooo.. a smaller fix than I thought, but still a fix.

@simonhamp simonhamp merged commit e0624eb into main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants