This repository was archived by the owner on May 27, 2026. It is now read-only.
fix: take into account all changed keys#231
Merged
SRWieZ merged 1 commit intoJun 30, 2025
Merged
Conversation
SRWieZ
approved these changes
Jun 29, 2025
SRWieZ
approved these changes
Jun 29, 2025
PeteBishwhip
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Account for all changed keys in settingsStore.onDidAnyChange
This commit addresses an issue where only the first changed key was being processed when multiple settings were updated simultaneously. The previous implementation used
Object.keys(newValue).find()which stops after finding the first difference.The updated code now iterates through all keys in the
newValueobject and compares them to their corresponding values inoldValue. This ensures that every changed setting triggers thenotifyLaravelfunction, providing a complete and accurate representation of settings modifications.Specifically, this change is crucial in scenarios where:
clear()orreset()are called on the settings store.The
Object.keys(newValue).filter()method now obtains all changed keys, which are each sent to thenotifyLaravelto update the backend for each relevant setting.I made the same pull request before, but deleted the fork of the repository, not knowing the side effects (this closed the pull request).
Previous pull request #210