remove workingDirectory from Windows deep-link handler#241
Conversation
SRWieZ
left a comment
There was a problem hiding this comment.
Can't we change OpenedFromURL to include this directory as a nullable parameter? I believe it's useful information to have. I plan to use it in one of my project-based projects, such as when I run phpstorm in a project directory and it opens the project directly.
|
We only use the second-instance method for deep-links on windows & linux. As it stands this argument is not passed when handling deep links on mac at all. If you want to keep it in we should add this on mac too, but I'm not exactly sure what this parameter is supposed to be 🤔 https://www.electronjs.org/docs/latest/api/app#event-second-instance |
|
After reading this again, I approve! https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app |
Deeplink handling on Windows was passing a
workingDirectoryparameter to theOpenedFromURLevent.This was causing issues when opening deep-links on Windows
Fixes: https://github.com/NativePHP/laravel/issues/599