Skip to content

remove workingDirectory from Windows deep-link handler#241

Merged
simonhamp merged 2 commits into
mainfrom
fix/remove-redundant-workingDirectory-parameter-from-windows-deep-link-event
Aug 4, 2025
Merged

remove workingDirectory from Windows deep-link handler#241
simonhamp merged 2 commits into
mainfrom
fix/remove-redundant-workingDirectory-parameter-from-windows-deep-link-event

Conversation

@gwleuverink
Copy link
Copy Markdown
Contributor

Deeplink handling on Windows was passing a workingDirectory parameter to the OpenedFromURL event.

This was causing issues when opening deep-links on Windows

Fixes: https://github.com/NativePHP/laravel/issues/599

@gwleuverink gwleuverink requested a review from a team August 1, 2025 21:17
@gwleuverink gwleuverink self-assigned this Aug 1, 2025
@gwleuverink gwleuverink added the bug Something isn't working label Aug 1, 2025
Copy link
Copy Markdown
Member

@SRWieZ SRWieZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we change OpenedFromURL to include this directory as a nullable parameter? I believe it's useful information to have. I plan to use it in one of my project-based projects, such as when I run phpstorm in a project directory and it opens the project directly.

@gwleuverink
Copy link
Copy Markdown
Contributor Author

We only use the second-instance method for deep-links on windows & linux. As it stands this argument is not passed when handling deep links on mac at all.

If you want to keep it in we should add this on mac too, but I'm not exactly sure what this parameter is supposed to be 🤔

https://www.electronjs.org/docs/latest/api/app#event-second-instance

@SRWieZ
Copy link
Copy Markdown
Member

SRWieZ commented Aug 2, 2025

After reading this again, I approve!

https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app

@simonhamp simonhamp merged commit 8f16862 into main Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling deep link gives error in DispatchEventFromAppController

3 participants