Fix free plugin claim expiry date to match extended offer (#271)

* Fix free plugin claim expiry date to match extended offer period

The claimFreePlugins controller action still had the old Feb 28 expiry
while shouldSeeFreePluginsOffer had already been updated to May 31.
This caused users to see the offer banner but get "expired" when claiming.
Also adds tests covering the claim flow and expiry boundaries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix trailing newline formatting (pint)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix malformed UTF-8 in docs search snippet extraction

Use mb_strcut() instead of substr() to avoid cutting multi-byte
UTF-8 characters (em dashes, emoji, etc.) in half when extracting
search snippets, which caused JSON encoding failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: simonhamp

app/Http/Controllers/CustomerLicenseController.php

@@ -134,7 +134,7 @@ public function claimFreePlugins(): RedirectResponse
         $user = Auth::user();
 
         // Check if offer has expired
-        if (now()->gt('2026-02-28 23:59:59')) {
+        if (now()->gt('2026-05-31 23:59:59')) {
             return to_route('dashboard')
                 ->with('error', 'This offer has expired.');
         }

app/Services/DocsSearchService.php

@@ -301,12 +301,12 @@ protected function extractSnippet(string $content, array $queryTerms, int $lengt
             $pos = strpos($contentLower, $term);
             if ($pos !== false) {
                 $start = max(0, $pos - 50);
-                $snippet = substr($content, $start, $length);
+                $snippet = mb_strcut($content, $start, $length, 'UTF-8');
 
                 if ($start > 0) {
                     $snippet = '...'.$snippet;
                 }
-                if ($start + $length < strlen($content)) {
+                if ($start + $length < mb_strlen($content, '8bit')) {
                     $snippet .= '...';
                 }
 

tests/Feature/ClaimFreePluginsTest.php

@@ -0,0 +1,125 @@
+<?php
+
+namespace Tests\Feature;
+
+use App\Models\License;
+use App\Models\Plugin;
+use App\Models\PluginLicense;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Carbon;
+use Tests\TestCase;
+
+class ClaimFreePluginsTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_eligible_user_can_claim_free_plugins(): void
+    {
+        $this->travelTo(Carbon::parse('2026-03-15'));
+
+        $user = User::factory()->create();
+        License::factory()->create([
+            'user_id' => $user->id,
+            'created_at' => '2025-12-01',
+        ]);
+
+        foreach (User::FREE_PLUGINS_OFFER as $name) {
+            Plugin::factory()->approved()->create(['name' => $name]);
+        }
+
+        $response = $this->actingAs($user)
+            ->post(route('customer.claim-free-plugins'));
+
+        $response->assertRedirectToRoute('dashboard');
+        $response->assertSessionHas('success');
+
+        $this->assertDatabaseCount('plugin_licenses', count(User::FREE_PLUGINS_OFFER));
+    }
+
+    public function test_claim_is_rejected_after_offer_expires(): void
+    {
+        $this->travelTo(Carbon::parse('2026-06-01'));
+
+        $user = User::factory()->create();
+        License::factory()->create([
+            'user_id' => $user->id,
+            'created_at' => '2025-12-01',
+        ]);
+
+        foreach (User::FREE_PLUGINS_OFFER as $name) {
+            Plugin::factory()->approved()->create(['name' => $name]);
+        }
+
+        $response = $this->actingAs($user)
+            ->post(route('customer.claim-free-plugins'));
+
+        $response->assertRedirectToRoute('dashboard');
+        $response->assertSessionHas('error', 'This offer has expired.');
+
+        $this->assertDatabaseCount('plugin_licenses', 0);
+    }
+
+    public function test_claim_is_allowed_on_last_day_of_offer(): void
+    {
+        $this->travelTo(Carbon::parse('2026-05-31 23:00:00'));
+
+        $user = User::factory()->create();
+        License::factory()->create([
+            'user_id' => $user->id,
+            'created_at' => '2025-12-01',
+        ]);
+
+        foreach (User::FREE_PLUGINS_OFFER as $name) {
+            Plugin::factory()->approved()->create(['name' => $name]);
+        }
+
+        $response = $this->actingAs($user)
+            ->post(route('customer.claim-free-plugins'));
+
+        $response->assertRedirectToRoute('dashboard');
+        $response->assertSessionHas('success');
+    }
+
+    public function test_ineligible_user_cannot_claim_free_plugins(): void
+    {
+        $this->travelTo(Carbon::parse('2026-03-15'));
+
+        $user = User::factory()->create();
+
+        foreach (User::FREE_PLUGINS_OFFER as $name) {
+            Plugin::factory()->approved()->create(['name' => $name]);
+        }
+
+        $response = $this->actingAs($user)
+            ->post(route('customer.claim-free-plugins'));
+
+        $response->assertRedirectToRoute('dashboard');
+        $response->assertSessionHas('error', 'You are not eligible for this offer.');
+    }
+
+    public function test_user_cannot_claim_plugins_twice(): void
+    {
+        $this->travelTo(Carbon::parse('2026-03-15'));
+
+        $user = User::factory()->create();
+        License::factory()->create([
+            'user_id' => $user->id,
+            'created_at' => '2025-12-01',
+        ]);
+
+        foreach (User::FREE_PLUGINS_OFFER as $name) {
+            $plugin = Plugin::factory()->approved()->create(['name' => $name]);
+            PluginLicense::factory()->create([
+                'user_id' => $user->id,
+                'plugin_id' => $plugin->id,
+            ]);
+        }
+
+        $response = $this->actingAs($user)
+            ->post(route('customer.claim-free-plugins'));
+
+        $response->assertRedirectToRoute('dashboard');
+        $response->assertSessionHas('message', 'You have already claimed all the free plugins.');
+    }
+}

tests/Feature/Filament/ResyncPluginActionTest.php

@@ -64,4 +64,4 @@ public function test_resync_action_hidden_when_no_repository_url(): void
             ->test(EditPlugin::class, ['record' => $plugin->getRouteKey()])
             ->assertActionHidden('resync');
     }
-}
+}