Skip to content

Commit 813b606

Browse files
simonhampclaude
andcommitted
Add webhook to required review checks, remove dead customer plugin controller
- Include webhook_installed in required approval checks (Plugin model, Filament admin, notifications, customer dashboard) - Move webhook setup instructions into the review checks section - Update best-practices docs: replace support email with support channel, add license/release/webhook requirements - Delete dead code: CustomerPluginController, its form requests, and old customer/plugins Blade views (replaced by Livewire components) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4c4037d commit 813b606

File tree

16 files changed

+115
-1578
lines changed

16 files changed

+115
-1578
lines changed

app/Filament/Resources/PluginResource.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,10 @@ public static function form(Schema $schema): Schema
101101
? ''.($record->review_checks['release_version'] ?? '')
102102
: '❌ Missing'),
103103

104+
Forms\Components\Placeholder::make('review_webhook')
105+
->label('Webhook Configured (required)')
106+
->content(fn (?Plugin $record) => $record?->webhook_installed ? '✅ Configured' : '❌ Not configured'),
107+
104108
Forms\Components\Placeholder::make('review_ios')
105109
->label('iOS Support')
106110
->content(fn (?Plugin $record) => ($record?->review_checks['supports_ios'] ?? false) ? '✅ Found' : '❌ Missing'),

app/Filament/Resources/PluginResource/Pages/EditPlugin.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,12 @@ protected function getHeaderActions(): array
195195
return;
196196
}
197197

198+
$webhookConfigured = $this->record->webhook_installed;
199+
198200
$lines = collect([
199201
['License file *', $checks['has_license_file']],
200202
['Release version *', $checks['has_release_version'] ? $checks['release_version'] : false],
203+
['Webhook *', $webhookConfigured],
201204
['iOS support', $checks['supports_ios']],
202205
['Android support', $checks['supports_android']],
203206
['JS support', $checks['supports_js']],
@@ -221,13 +224,13 @@ protected function getHeaderActions(): array
221224
'supports_ios', 'supports_android', 'supports_js',
222225
'requires_mobile_sdk',
223226
'has_ios_min_version', 'has_android_min_version',
224-
])->filter()->count();
227+
])->filter()->count() + ($webhookConfigured ? 1 : 0);
225228

226229
Notification::make()
227-
->title("Review checks complete ({$passed}/8 passed)")
230+
->title("Review checks complete ({$passed}/9 passed)")
228231
->body(new HtmlString($lines))
229232
->duration(15000)
230-
->color($passed === 8 ? 'success' : 'warning')
233+
->color($passed === 9 ? 'success' : 'warning')
231234
->send();
232235
}),
233236

app/Http/Controllers/CustomerPluginController.php

Lines changed: 0 additions & 290 deletions
This file was deleted.

app/Http/Requests/SubmitPluginRequest.php

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)