Add plugin submission checks and require support channel#305
Merged
Conversation
…on submission - Add automated checks for license file (LICENSE/LICENSE.md/LICENSE.txt) and release version (GitHub releases/tags) in ReviewPluginRepository - Block plugin approval in Filament admin until required checks pass - Split customer-facing review checks into required and additional sections - Remove automated support email extraction from README - Make support channel required on plugin submission with email/URL validation - Allow users to edit support channel from their plugin dashboard - Update all related tests and notifications Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ntroller - Include webhook_installed in required approval checks (Plugin model, Filament admin, notifications, customer dashboard) - Move webhook setup instructions into the review checks section - Update best-practices docs: replace support email with support channel, add license/release/webhook requirements - Delete dead code: CustomerPluginController, its form requests, and old customer/plugins Blade views (replaced by Livewire components) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # resources/views/customer/plugins/create.blade.php # resources/views/customer/plugins/index.blade.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewPluginRepositorynow verifies that the repo contains a license file (LICENSE, LICENSE.md, or LICENSE.txt) and has a GitHub release or tag. These are required checks — plugins cannot be approved until both pass.Test plan
ReviewPluginRepositoryTest(license file detection, release version detection, full integration)CustomerPluginReviewChecksTest(submission runs checks, notification includes failing checks)PluginReviewChecksIncompleteTest(email rendering, all-failing, subject line)PluginSubmissionNotesTest(notes, support channel email/URL, required validation, invalid format validation)🤖 Generated with Claude Code