Skip to content

Only apply scroll-lock padding compensation on desktop#311

Merged
simonhamp merged 1 commit intomainfrom
fix-popover-scroll-padding
Mar 29, 2026
Merged

Only apply scroll-lock padding compensation on desktop#311
simonhamp merged 1 commit intomainfrom
fix-popover-scroll-padding

Conversation

@simonhamp
Copy link
Copy Markdown
Member

@simonhamp simonhamp commented Mar 29, 2026

Summary

  • Wraps the padding-right compensation for Flux popover scroll-lock in @media (pointer: fine) so it only applies on desktop devices with a mouse/trackpad
  • On mobile/touch devices there are no visible scrollbars, so the padding was adding unnecessary space

Test plan

  • Open a page with a Flux popover on desktop — verify padding still compensates for the scrollbar when popover is open
  • Open the same page on mobile — verify no extra padding appears when the popover locks scroll

🤖 Generated with Claude Code

The padding-right added when Flux popovers lock scroll is only needed
on desktop where custom scrollbars are visible. Wrap in @media (pointer: fine)
to avoid unnecessary padding on mobile/touch devices.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@simonhamp simonhamp marked this pull request as ready for review March 29, 2026 17:57
@simonhamp simonhamp merged commit ec1b4d7 into main Mar 29, 2026
2 checks passed
@simonhamp simonhamp deleted the fix-popover-scroll-padding branch March 29, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant