Fix Filament null username crash on impersonate banner#316
Merged
Conversation
… name Implement HasName interface on User model with getFilamentName() that falls back to display_name → name → email, preventing the ViewException when the filament-impersonate banner renders for users with null names. Closes #48 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filament\Models\Contracts\HasNameon theUsermodel with agetFilamentName()methoddisplay_name→name→email, ensuring a non-null string is always returnedViewExceptionwhen thefilament-impersonatebanner renders for users whosenamecolumn is nullRoot Cause
Users created via OAuth (e.g. GitHub) can have a
nullnameattribute. When an admin impersonates such a user, thefilament-impersonatebanner callsFilamentManager::getUserName(), which returns$user->getAttributeValue('name')with astringreturn type — causing aTypeError.Closes #48
Test plan
getFilamentName()returnsnamewhen presentgetFilamentName()returnsdisplay_namewhennameis nullgetFilamentName()returnsemailwhen bothnameanddisplay_nameare nullgetFilamentName()always returns a string🤖 Generated with Claude Code