Fix Route [login] not defined on paid plugin show page#339
Merged
Conversation
The plugin-show Blade view used route('login') which doesn't exist.
The correct named route is 'customer.login'. This caused a 500 error
for unauthenticated users viewing paid plugin pages.
Closes #56
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route('login')→route('customer.login')inplugin-show.blade.phpfor unauthenticated users viewing paid plugin pagesPluginShowPaidGuestTestto verify paid plugin pages render correctly for guestsProblem
Unauthenticated users visiting paid plugin pages (e.g.
/plugins/nativephp/mobile-firebase) got a 500 error becauseroute('login')was used but no route with that name exists. The correct route name iscustomer.login.Closes #56
Test plan
PluginShowPaidGuestTestpasses — verifies guest can view paid plugin page with login linkPluginShowMobileVersionTesttests still pass🤖 Generated with Claude Code