Skip to content

Fix admin plugin list to show drafts when filtering by Draft status#363

Merged
simonhamp merged 1 commit intomainfrom
fix-admin-draft-filter
Apr 14, 2026
Merged

Fix admin plugin list to show drafts when filtering by Draft status#363
simonhamp merged 1 commit intomainfrom
fix-admin-draft-filter

Conversation

@simonhamp
Copy link
Copy Markdown
Member

Summary

  • Moved draft plugin exclusion from the base ListPlugins::getTableQuery() into the status SelectFilter's custom query() callback
  • Drafts are still hidden by default (no filter selected), but now appear when explicitly filtering by "Draft" status
  • Previously, selecting "Draft" in the status filter produced conflicting WHERE clauses (status != 'draft' AND status = 'draft') and returned no results

Test plan

  • Added PluginListDraftFilterTest with two test cases:
    • Draft plugins hidden by default
    • Draft plugins visible when filtering by Draft status
  • All 87 Filament tests pass

🤖 Generated with Claude Code

The base query in ListPlugins unconditionally excluded drafts, so
selecting "Draft" in the status filter produced conflicting WHERE
clauses and returned no results. Moved the draft exclusion logic
into the SelectFilter's custom query callback so drafts are hidden
by default but visible when explicitly filtered.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@simonhamp simonhamp marked this pull request as ready for review April 14, 2026 12:27
@simonhamp simonhamp merged commit eb8e70f into main Apr 14, 2026
2 checks passed
@simonhamp simonhamp deleted the fix-admin-draft-filter branch April 14, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant