chore(audio-context): performance op

Author: triniwiz

packages/audio-context/platforms/android/audiocontext-release.aar

@@ -1,4 +1,5 @@
 #import "NSCAudioContext.h"
+#include <stdlib.h>
 
 typedef NS_ENUM(NSInteger, ParamEventType) {
     ParamEventTypeSet = 0,
@@ -23,6 +24,12 @@ - (instancetype)initWithType:(ParamEventType)type time:(double)time value:(doubl
 }
 @end
 
+typedef struct {
+    ParamEventType type;
+    double time;
+    double value;
+} NSCParamEventSnapshot;
+
 @implementation NSCAudioParam {
     __strong NSCAudioContext *_context;
     NSMutableArray<ParamEvent *> *_events;
@@ -182,7 +189,18 @@ - (BOOL)fillValuesForRange:(double)startTime
         return NO;
     }
 
-    struct { ParamEventType type; double time; double value; } evts[evtCount];
+    const NSUInteger kStackSnapshotCapacity = 64;
+    NSCParamEventSnapshot stackEvents[kStackSnapshotCapacity];
+    NSCParamEventSnapshot *evts = stackEvents;
+    if (evtCount > kStackSnapshotCapacity) {
+        evts = (NSCParamEventSnapshot *)malloc(sizeof(NSCParamEventSnapshot) * evtCount);
+        if (!evts) {
+            double cur = _currentValueInternal;
+            [_lock unlock];
+            for (NSInteger i = 0; i < frameCount; ++i) outValues[i] = cur;
+            return NO;
+        }
+    }
     for (NSUInteger i = 0; i < evtCount; ++i) {
         ParamEvent *e = _events[i];
         evts[i].type = e.type;
@@ -214,6 +232,7 @@ - (BOOL)fillValuesForRange:(double)startTime
             }
         }
         for (NSInteger i = 0; i < frameCount; ++i) outValues[i] = v;
+        if (evts != stackEvents) free(evts);
         return YES;
     }
 
@@ -244,77 +263,20 @@ - (BOOL)fillValuesForRange:(double)startTime
         }
         outValues[i] = value;
     }
+    if (evts != stackEvents) free(evts);
     return YES;
 }
 
 - (NSArray<NSNumber *> *)getValuesForRange:(double)startTime :(double)sampleRate :(NSInteger)frameCount {
-    [_lock lock];
-    NSArray<ParamEvent *> *evts = [_events copy];
-    double def = _defaultValue;
-    [_lock unlock];
-    
+    if (frameCount <= 0) return @[];
+
+    NSMutableData *scratch = [NSMutableData dataWithLength:sizeof(double) * (NSUInteger)frameCount];
+    double *values = (double *)scratch.mutableBytes;
+    [self fillValuesForRange:startTime sampleRate:sampleRate frameCount:frameCount into:values];
+
     NSMutableArray<NSNumber *> *out = [NSMutableArray arrayWithCapacity:frameCount];
-    if ([_automationRate isEqualToString:@"k-rate"]) {
-        double v = def;
-        if (evts.count == 0) {
-            v = def;
-        } else {
-            NSUInteger idx = [evts indexOfObjectPassingTest:^BOOL(ParamEvent *obj, NSUInteger idx, BOOL *stop) {
-                return obj.time > startTime;
-            }];
-            if (idx == NSNotFound) {
-                v = evts.lastObject.value;
-            } else if (idx == 0) {
-                v = def;
-            } else {
-                ParamEvent *prev = evts[idx - 1];
-                ParamEvent *next = evts[idx];
-                if (next.type == ParamEventTypeLinearRamp) {
-                    double t0 = prev.time;
-                    double t1 = next.time;
-                    if (t1 <= t0) v = next.value;
-                    else {
-                        double ratio = fmax(0.0, fmin(1.0, (startTime - t0) / (t1 - t0)));
-                        v = prev.value + (next.value - prev.value) * ratio;
-                    }
-                } else {
-                    v = prev.value;
-                }
-            }
-        }
-        for (NSInteger i = 0; i < frameCount; ++i) [out addObject:@(v)];
-        return out;
-    }
-    
-    NSInteger nextEventIndex = 0;
-    NSInteger previousEventIndex = -1;
     for (NSInteger i = 0; i < frameCount; ++i) {
-        double t = startTime + (double)i / sampleRate;
-        while (nextEventIndex < evts.count && evts[nextEventIndex].time <= t) {
-            previousEventIndex = nextEventIndex;
-            nextEventIndex += 1;
-        }
-        double value;
-        if (previousEventIndex < 0) {
-            value = def;
-        } else if (nextEventIndex >= evts.count) {
-            value = evts[previousEventIndex].value;
-        } else {
-            ParamEvent *prev = evts[previousEventIndex];
-            ParamEvent *next = evts[nextEventIndex];
-            if (next.type == ParamEventTypeLinearRamp) {
-                double t0 = prev.time;
-                double t1 = next.time;
-                if (t1 <= t0) value = next.value;
-                else {
-                    double ratio = fmax(0.0, fmin(1.0, (t - t0) / (t1 - t0)));
-                    value = prev.value + (next.value - prev.value) * ratio;
-                }
-            } else {
-                value = prev.value;
-            }
-        }
-        [out addObject:@(value)];
+        [out addObject:@(values[i])];
     }
     return out;
 }

packages/audio-context/platforms/ios/src/NSCAudioParam.m

@@ -748,6 +748,8 @@ + (nullable instancetype)attachToPlayer:(AVPlayer *)player
         dispatch_source_set_timer(sched, dispatch_time(DISPATCH_TIME_NOW, 0), interval, (uint64_t)(NSEC_PER_MSEC * 5));
         __weak typeof(pnode) weakP = pnode;
         __weak typeof(self_) weakSelfTap = self_;
+        __block uint8_t *playerScratch = NULL;
+        __block uint32_t playerScratchBytes = 0;
         dispatch_source_set_event_handler(sched, ^{
           __strong typeof(weakP) strongP = weakP;
           __strong typeof(weakSelfTap) strongTap = weakSelfTap;
@@ -776,26 +778,36 @@ + (nullable instancetype)attachToPlayer:(AVPlayer *)player
           }
 
           const uint32_t framesPerBuffer = 1024;
+          uint32_t scratchNeeded = framesPerBuffer * bytesPerFrameLocal;
+          if (scratchNeeded > playerScratchBytes) {
+            void *resized = realloc(playerScratch, (size_t)scratchNeeded);
+            if (!resized) return;
+            playerScratch = (uint8_t *)resized;
+            playerScratchBytes = scratchNeeded;
+          }
+
+          AVAudioFormat *pnodeFormat = nil;
+          @try {
+            pnodeFormat = [strongP outputFormatForBus:0];
+          } @catch (NSException *e) {
+            pnodeFormat = nil;
+          }
+          AVAudioFormat *useFormat = pnodeFormat ?: nodeFormat;
+          uint32_t srcChannels = channelCount;
+          uint32_t dstChannels = (uint32_t)(useFormat.channelCount);
+
           while (framesAvailable > 0) {
             uint32_t framesThis = framesAvailable >= framesPerBuffer ? framesPerBuffer : framesAvailable;
             uint32_t bytesNeeded = framesThis * bytesPerFrameLocal;
-            uint8_t *tmpBuf = (uint8_t *)malloc((size_t)bytesNeeded);
-            if (!tmpBuf) break;
-            uint32_t got = NSCRingRead(&coreLocal->ring, tmpBuf, bytesNeeded);
+            uint32_t got = NSCRingRead(&coreLocal->ring, playerScratch, bytesNeeded);
             uint32_t gotFrames = got / bytesPerFrameLocal;
-            if (gotFrames == 0) { free(tmpBuf); break; }
+            if (gotFrames == 0) { break; }
             AVAudioFrameCount fc = (AVAudioFrameCount)gotFrames;
 
-            AVAudioFormat *pnodeFormat = nil;
-            @try { pnodeFormat = [strongP outputFormatForBus:0]; } @catch (NSException *e) { pnodeFormat = nil; }
-            AVAudioFormat *useFormat = pnodeFormat ?: nodeFormat;
-
             AVAudioPCMBuffer *pcm = [[AVAudioPCMBuffer alloc] initWithPCMFormat:useFormat frameCapacity:fc];
             if (pcm) {
               pcm.frameLength = fc;
-              float *srcFloat = (float *)tmpBuf;
-              uint32_t srcChannels = channelCount;
-              uint32_t dstChannels = (uint32_t)(useFormat.channelCount);
+              float *srcFloat = (float *)playerScratch;
 
               if (dstChannels == srcChannels) {
                 for (UInt32 ch = 0; ch < dstChannels; ch++) {
@@ -827,12 +839,18 @@ + (nullable instancetype)attachToPlayer:(AVPlayer *)player
 
               [strongP scheduleBuffer:pcm completionHandler:NULL];
             }
-            free(tmpBuf);
             avail = NSCRingAvailableRead(&coreLocal->ring);
             framesAvailable = avail / bytesPerFrameLocal;
             if (framesThis < framesPerBuffer) break;
           }
         });
+        dispatch_source_set_cancel_handler(sched, ^{
+          if (playerScratch) {
+            free(playerScratch);
+            playerScratch = NULL;
+            playerScratchBytes = 0;
+          }
+        });
         dispatch_resume(sched);
         self_->_playerSchedulingSource = sched;
       }