revert: \"fix: prevent crash during debug on fast view churn (like with HMR)\" - restore original revert

Agent-Logs-Url: https://github.com/NativeScript/ios/sessions/62444c68-20cd-4f29-98e1-008f34ee1416

Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>

Author: Copilot

NativeScript/runtime/ArgConverter.mm

@@ -7,7 +7,6 @@
 #include "Interop.h"
 #include "Helpers.h"
 #include "Runtime.h"
-#include "RuntimeConfig.h"
 
 using namespace v8;
 using namespace std;
@@ -28,24 +27,7 @@
     bool callSuper = false;
     if (instanceMethod) {
         BaseDataWrapper* wrapper = tns::GetValue(isolate, receiver);
-        
-        if (wrapper == nullptr) {
-            // During fast view churn like HMR in development, JS objects can outlive their
-            // native wrappers briefly. In Debug, throw a catchable JS error instead of crashing.
-            // In Release, assert so crash reporting can capture unexpected cases.
-            if (RuntimeConfig.IsDebug) {
-                const char* selectorStr = meta ? meta->selectorAsString() : "<unknown>";
-                const char* jsNameStr = meta ? meta->jsName() : "<unknown>";
-                const char* classNameStr = klass ? class_getName(klass) : "<unknown>";
-                std::string errMsg = std::string("Cannot call method '") + jsNameStr +
-                    "' on a disposed native object (class: " + classNameStr +
-                    ", selector: " + selectorStr + "). This can happen during HMR or fast view churn.";
-                isolate->ThrowException(Exception::Error(tns::ToV8String(isolate, errMsg)));
-                return v8::Undefined(isolate);
-            } else {
-                tns::Assert(false, isolate);
-            }
-        }
+        tns::Assert(wrapper != nullptr, isolate);
 
         if (wrapper->Type() == WrapperType::ObjCAllocObject) {
             ObjCAllocDataWrapper* allocWrapper = static_cast<ObjCAllocDataWrapper*>(wrapper);
@@ -61,19 +43,7 @@
             // For extended classes we will call the base method
             callSuper = isMethodCallback && it != cache->ClassPrototypes.end();
         } else {
-            if (RuntimeConfig.IsDebug) {
-                const char* selectorStr = meta ? meta->selectorAsString() : "<unknown>";
-                const char* jsNameStr = meta ? meta->jsName() : "<unknown>";
-                const char* classNameStr = klass ? class_getName(klass) : "<unknown>";
-                std::string errMsg = std::string("Unexpected receiver wrapper type ") +
-                    std::to_string((int)wrapper->Type()) + " for method '" + jsNameStr +
-                    "' (class: " + classNameStr + ", selector: " + selectorStr +
-                    "). This can happen during HMR or fast view churn.";
-                isolate->ThrowException(Exception::Error(tns::ToV8String(isolate, errMsg)));
-                return v8::Undefined(isolate);
-            } else {
-                tns::Assert(false, isolate);
-            }
+            tns::Assert(false, isolate);
         }
     }
 
@@ -908,7 +878,7 @@
     Local<Object> thiz = args.This();
     Isolate* isolate = args.GetIsolate();
     BaseDataWrapper* wrapper = tns::GetValue(isolate, thiz);
-    if (wrapper == nullptr || wrapper->Type() != WrapperType::ObjCObject) {
+    if (wrapper == nullptr && wrapper->Type() != WrapperType::ObjCObject) {
         return;
     }