Skip to content

Commit 41bc77c

Browse files
committed
chore: api updates
1 parent 7df1104 commit 41bc77c

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

NativeScript/NativeScript-Prefix.pch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#ifndef NativeScript_Prefix_pch
22
#define NativeScript_Prefix_pch
33

4-
#define NATIVESCRIPT_VERSION "8.9.0"
4+
#define NATIVESCRIPT_VERSION "8.9.3"
55

66
#ifdef DEBUG
77
#define SIZEOF_OFF_T 8

NativeScript/runtime/URLPatternImpl.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
#include "URLPatternImpl.h"
66

7+
#include <utility>
8+
79
#include "ModuleBinding.hpp"
810

911
using namespace std;
@@ -324,7 +326,9 @@ void URLPatternImpl::Ctor(const v8::FunctionCallbackInfo<v8::Value>& args) {
324326
if (args.Length() == 0) {
325327
auto thiz = args.This();
326328
auto init = ada::url_pattern_init{};
327-
auto url_pattern = ada::parse_url_pattern<v8_regex_provider>(init);
329+
ada::url_pattern_input input = init;
330+
auto url_pattern =
331+
ada::parse_url_pattern<v8_regex_provider>(std::move(input));
328332
if (!url_pattern) {
329333
isolate->ThrowException(v8::Exception::TypeError(
330334
tns::ToV8String(isolate, "Failed to construct URLPattern")));
@@ -414,7 +418,7 @@ void URLPatternImpl::Ctor(const v8::FunctionCallbackInfo<v8::Value>& args) {
414418
}
415419

416420
auto url_pattern = ada::parse_url_pattern<v8_regex_provider>(
417-
arg0, base_url.has_value() ? &base_url_view : nullptr,
421+
std::move(arg0), base_url.has_value() ? &base_url_view : nullptr,
418422
options.has_value() ? &options.value() : nullptr);
419423
if (!url_pattern) {
420424
isolate->ThrowException(v8::Exception::TypeError(

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@
4444
"clang-format -i"
4545
]
4646
}
47-
}
47+
}

0 commit comments

Comments
 (0)