perf: use const strings in inspector messages

Author: edusperoni

NativeScript/inspector/InspectorServer.h

@@ -12,12 +12,13 @@ namespace v8_inspector {
 class InspectorServer {
  public:
   static in_port_t Init(
-      std::function<void(std::function<void(std::string)>)> onClientConnected,
-      std::function<void(std::string)> onMessage);
+      std::function<void(std::function<void(const std::string&)>)>
+          onClientConnected,
+      std::function<void(const std::string&)> onMessage);
 
  private:
   static void Send(dispatch_io_t channel, dispatch_queue_t queue,
-                   std::string message);
+                   const std::string& message);
 };
 
 }  // namespace v8_inspector

NativeScript/inspector/InspectorServer.mm

@@ -6,8 +6,8 @@
 namespace v8_inspector {
 
 in_port_t InspectorServer::Init(
-    std::function<void(std::function<void(std::string)>)> onClientConnected,
-    std::function<void(std::string)> onMessage) {
+    std::function<void(std::function<void(const std::string&)>)> onClientConnected,
+    std::function<void(const std::string&)> onMessage) {
   in_port_t listenPort = 18183;
 
   int serverSocket = -1;
@@ -120,7 +120,8 @@
   return listenPort;
 }
 
-void InspectorServer::Send(dispatch_io_t channel, dispatch_queue_t queue, std::string message) {
+void InspectorServer::Send(dispatch_io_t channel, dispatch_queue_t queue,
+                           const std::string& message) {
   NSString* str = [NSString stringWithUTF8String:message.c_str()];
   NSUInteger length = [str lengthOfBytesUsingEncoding:NSUTF16LittleEndianStringEncoding];
 

NativeScript/inspector/JsV8InspectorClient.h

@@ -55,7 +55,7 @@ class JsV8InspectorClient : V8InspectorClient, V8Inspector::Channel {
   dispatch_queue_t messagesQueue_;
   dispatch_queue_t messageLoopQueue_;
   dispatch_semaphore_t messageArrived_;
-  std::function<void(std::string)> sender_;
+  std::function<void(const std::string&)> sender_;
   bool isWaitingForDebugger_;
   bool hasScheduledDebugBreak_;
 
@@ -68,8 +68,9 @@ class JsV8InspectorClient : V8InspectorClient, V8Inspector::Channel {
   void enableInspector(int argc, char** argv);
   void createInspectorSession();
   void notify(std::unique_ptr<StringBuffer> message);
-  void onFrontendConnected(std::function<void(std::string)> sender);
-  void onFrontendMessageReceived(std::string message);
+  void notify(const std::string& message);
+  void onFrontendConnected(std::function<void(const std::string&)> sender);
+  void onFrontendMessageReceived(const std::string& message);
   std::string PumpMessage();
   static void registerDomainDispatcherCallback(
       const v8::FunctionCallbackInfo<v8::Value>& args);

NativeScript/inspector/JsV8InspectorClient.mm

@@ -66,8 +66,10 @@
       NOTIFICATION("AttachRequest"), &attachRequestSubscription, dispatch_get_main_queue(),
       ^(int token) {
         in_port_t listenPort = InspectorServer::Init(
-            [this](std::function<void(std::string)> sender) { this->onFrontendConnected(sender); },
-            [this](std::string message) { this->onFrontendMessageReceived(message); });
+            [this](std::function<void(const std::string&)> sender) {
+              this->onFrontendConnected(sender);
+            },
+            [this](const std::string& message) { this->onFrontendMessageReceived(message); });
 
         LOG_DEBUGGER_PORT(listenPort);
         notify_post(NOTIFICATION("ReadyForAttach"));
@@ -99,7 +101,7 @@
   notify_cancel(waitForDebuggerSubscription);
 }
 
-void JsV8InspectorClient::onFrontendConnected(std::function<void(std::string)> sender) {
+void JsV8InspectorClient::onFrontendConnected(std::function<void(const std::string&)> sender) {
   if (this->isWaitingForDebugger_) {
     this->isWaitingForDebugger_ = NO;
     CFRunLoopRef runloop = CFRunLoopGetMain();
@@ -118,7 +120,7 @@
   this->isConnected_ = true;
 }
 
-void JsV8InspectorClient::onFrontendMessageReceived(std::string message) {
+void JsV8InspectorClient::onFrontendMessageReceived(const std::string& message) {
   dispatch_sync(this->messagesQueue_, ^{
     this->messages_.push(message);
     dispatch_semaphore_signal(messageArrived_);
@@ -243,10 +245,12 @@
 
 void JsV8InspectorClient::notify(std::unique_ptr<StringBuffer> message) {
   StringView stringView = message->string();
-  std::string value = ToStdString(stringView);
+  notify(ToStdString(stringView));
+}
 
+void JsV8InspectorClient::notify(const std::string& message) {
   if (this->sender_) {
-    this->sender_(value);
+    this->sender_(message);
   }
 }
 
@@ -280,8 +284,9 @@
 
   if (message.find("Tracing.end") != std::string::npos) {
     tracing_agent_->end();
-    std::string res = tracing_agent_->getLastTrace();
-    tracing_agent_->SendToDevtools(context, res);
+    for (const auto& traceMessage : tracing_agent_->getLastTrace()) {
+      notify(traceMessage);
+    }
     return;
   }