fix: prefer JS subclass property accessors

Author: DjDeveloperr

NativeScript/ffi/shared/bridge/HostObjects.mm

@@ -1814,16 +1814,14 @@ throw JSError(
     // methods); defer so the engine resolves them instead of the bridge
     // returning a registered getter IMP as a raw callable.
     if (isEngineExtendedInstance) {
-#ifdef NATIVESCRIPT_NATIVE_API_HOST_EXPLICIT_OVERRIDE
-      // Engines whose exotic property handler invokes prototype accessors with
-      // the wrong receiver need the JS-prototype getter resolved here with this
-      // instance as the receiver.
+      // Prefer JS prototype accessors before falling back to runtime ObjC
+      // getters; otherwise an ObjC getter implemented by the JS subclass can
+      // re-enter the same JS accessor recursively.
       bool found = false;
       Value resolved = resolveEnginePrototypeGetter(runtime, property, &found);
       if (found) {
         return resolved;
       }
-#endif
       if (auto selector =
               runtimeReadablePropertyGetter(object_, property)) {
         return callObjectSelector(runtime, *selector, nullptr, nullptr, 0);

PROGRESS.md

@@ -17,6 +17,47 @@ TypeScript/UI worklets.
 
 ## Latest Update - 2026-06-30
 
+### 2026-06-30 01:44 EDT - JS subclass getters prefer prototype accessors before ObjC runtime getters
+
+- Scope check:
+  - Still on the RN-module branch, still fixing generic NativeScript runtime
+    behavior exposed by RN module work, and still not touching the original
+    `refactor` direct-engine backend goal.
+  - Simulator-only rule remains active; no physical devices were used.
+- CI finding:
+  - GitHub Actions run `28421961031` on `3b7a492c` kept macOS green and no
+    longer timed out on iOS.
+  - The previous iOS blocker passed:
+    `ApiTests.js NSMutableArrayMethods => passed`.
+  - The iOS suite completed with one remaining failure:
+    `ApiTests.js SpecialCaseProperty_When_CustomSelector_ImplementedInJS`.
+  - The failure output was a long repetition of `getter`, showing that a native
+    runtime property getter was re-entering the JS override instead of serving
+    the JS prototype accessor directly.
+- Change:
+  - JS-extended object property reads now resolve JS prototype getters before
+    falling back to runtime Objective-C property getters on every backend.
+  - This keeps JS-owned accessors in JS and prevents an ObjC getter implemented
+    by the same JS subclass from recursively re-entering the accessor.
+  - Source coverage guards the tracked runtime bridge and the RN mirror.
+- Verification:
+  - Focused construction/property guard test passed:
+    `node packages/react-native/test/runtime-instance-selector-base-dispatch.test.js`.
+  - Runtime RN JS tests passed:
+    `for f in packages/react-native/test/*.test.js; do node "$f" || exit 1; done`.
+  - `git diff --check` passed.
+  - `npm run check:ffi-boundaries` passed.
+  - Existing generated macOS project compile/link passed with
+    `xcodebuild -project dist/intermediates/macos/NativeScript.xcodeproj ...`.
+  - Full local `npm run test:ios` remains blocked by local host tooling:
+    `scripts/build_metadata_generator.sh` tries to link an x86_64 metadata
+    generator against an arm64-only Xcode libclang on this machine. CI remains
+    the simulator source of truth for iOS.
+- Still next:
+  - Commit/push this prototype-getter precedence fix and watch fresh PR CI.
+    Expected result: macOS remains green and iOS clears the last
+    `SpecialCaseProperty_When_CustomSelector_ImplementedInJS` failure.
+
 ### 2026-06-30 01:13 EDT - guard JS callbacks during subclass construction
 
 - Scope check:

packages/react-native/test/runtime-instance-selector-base-dispatch.test.js

@@ -56,6 +56,36 @@ for (const relativePath of [
   );
 }
 
+for (const relativePath of [
+  "NativeScript/ffi/shared/bridge/HostObjects.mm",
+  "packages/react-native/native-api/ffi/shared/bridge/HostObjects.mm",
+]) {
+  const source = fs.readFileSync(path.join(repoRoot, relativePath), "utf8");
+  const branchIndex = source.indexOf("if (isEngineExtendedInstance) {");
+  const resolveIndex = source.indexOf(
+    "Value resolved = resolveEnginePrototypeGetter(runtime, property, &found);",
+    branchIndex,
+  );
+  const nativeGetterIndex = source.indexOf(
+    "runtimeReadablePropertyGetter(object_, property)",
+    branchIndex,
+  );
+  const guardedIndex = source.lastIndexOf(
+    "#ifdef NATIVESCRIPT_NATIVE_API_HOST_EXPLICIT_OVERRIDE",
+    resolveIndex,
+  );
+
+  assert(
+    branchIndex !== -1 &&
+      resolveIndex !== -1 &&
+      nativeGetterIndex !== -1 &&
+      branchIndex < resolveIndex &&
+      resolveIndex < nativeGetterIndex &&
+      guardedIndex < branchIndex,
+    `${relativePath}: JS-subclassed property reads should prefer prototype getters before native runtime getters on every backend`,
+  );
+}
+
 for (const relativePath of [
   "NativeScript/ffi/shared/bridge/Callbacks.mm",
   "packages/react-native/native-api/ffi/shared/bridge/Callbacks.mm",