perf: tighten selector dispatch target resolution

Author: DjDeveloperr

NativeScript/ffi/hermes/NativeApiJsi.mm

@@ -341,13 +341,26 @@ throw JSError(runtime,
                         "Objective-C selector requires a native receiver.");
         }
 
-        NativeApiSelectorGroupCallTarget callTarget = selectorGroupMemberForCall(
-            receiver, selectorLookupClass, receiverIsClass, entry, count);
-        const std::string& selectorName = *callTarget.selectorName;
-        const NativeApiMember* selectedMember = callTarget.member;
-        if (prepared != nullptr && prepared->selectorName != selectorName) {
-          prepared = nullptr;
+        const bool propertyGetterCall =
+            entry.hasMember && entry.member.property && count == 0;
+        const std::string* selectorNamePtr = &entry.selectorName;
+        const NativeApiMember* selectedMember =
+            entry.hasMember ? &entry.member : nullptr;
+        bool callTargetCanPrepare = true;
+        if (prepared == nullptr || propertyGetterCall) {
+          NativeApiSelectorGroupCallTarget callTarget =
+              selectorGroupCallTargetForEntry(receiver, selectorLookupClass,
+                                              receiverIsClass, entry, count);
+          selectorNamePtr = callTarget.selectorName;
+          selectedMember = callTarget.member;
+          callTargetCanPrepare = callTarget.canPrepare;
+          if (prepared != nullptr && prepared->selectorName != *selectorNamePtr) {
+            prepared = nullptr;
+          }
         }
+        const std::string& selectorName =
+            prepared != nullptr && !propertyGetterCall ? prepared->selectorName
+                                                       : *selectorNamePtr;
 
         if (receiverIsClass) {
           Class methodClass = prepared != nullptr ? prepared->receiverClass : Nil;
@@ -365,8 +378,7 @@ throw JSError(runtime,
           selectorLookupClass = methodClass;
           receiver = static_cast<id>(methodClass);
         }
-        if (entry.hasMember && entry.member.property && count == 0 &&
-            !callTarget.canPrepare) {
+        if (propertyGetterCall && !callTargetCanPrepare) {
           return callObjCSelector(runtime, bridge, receiver, receiverIsClass,
                                   selectorName, selectedMember, nullptr, 0);
         }

NativeScript/ffi/jsc/NativeApiJSC.mm

@@ -1110,9 +1110,10 @@ throw JSError(runtime,
         entry.hasMember ? &entry.member : nullptr;
     bool callTargetCanPrepare = true;
     if (prepared == nullptr || propertyGetterCall) {
-      NativeApiSelectorGroupCallTarget callTarget = selectorGroupMemberForCall(
-          receiver, selectorLookupClass, data->receiverIsClass, entry,
-          argumentCount);
+      NativeApiSelectorGroupCallTarget callTarget =
+          selectorGroupCallTargetForEntry(receiver, selectorLookupClass,
+                                          data->receiverIsClass, entry,
+                                          argumentCount);
       selectorNamePtr = callTarget.selectorName;
       selectedMember = callTarget.member;
       callTargetCanPrepare = callTarget.canPrepare;

NativeScript/ffi/quickjs/NativeApiQuickJS.mm

@@ -1212,8 +1212,9 @@ throw JSError(runtime,
         entry.hasMember ? &entry.member : nullptr;
     bool callTargetCanPrepare = true;
     if (prepared == nullptr || propertyGetterCall) {
-      NativeApiSelectorGroupCallTarget callTarget = selectorGroupMemberForCall(
-          receiver, selectorLookupClass, data->receiverIsClass, entry, count);
+      NativeApiSelectorGroupCallTarget callTarget =
+          selectorGroupCallTargetForEntry(receiver, selectorLookupClass,
+                                          data->receiverIsClass, entry, count);
       selectorNamePtr = callTarget.selectorName;
       selectedMember = callTarget.member;
       callTargetCanPrepare = callTarget.canPrepare;

NativeScript/ffi/shared/bridge/ObjCBridge.mm

@@ -506,6 +506,16 @@ NativeApiSelectorGroupCallTarget selectorGroupMemberForCall(
   return {&entry.selectorName, &entry.member, true};
 }
 
+inline NativeApiSelectorGroupCallTarget selectorGroupCallTargetForEntry(
+    id receiver, Class lookupClass, bool receiverIsClass,
+    NativeApiSelectorGroupEntry& entry, size_t count) {
+  if (entry.hasMember && (!entry.member.property || count != 0)) {
+    return {&entry.selectorName, &entry.member, true};
+  }
+  return selectorGroupMemberForCall(receiver, lookupClass, receiverIsClass,
+                                    entry, count);
+}
+
 const NativeApiMember* selectPropertyMember(
     const std::vector<NativeApiMember>& members, const std::string& property,
     bool staticMethod) {

NativeScript/ffi/v8/NativeApiV8.mm

@@ -1234,8 +1234,9 @@ throw JSError(runtime,
         entry.hasMember ? &entry.member : nullptr;
     bool callTargetCanPrepare = true;
     if (prepared == nullptr || propertyGetterCall) {
-      NativeApiSelectorGroupCallTarget callTarget = selectorGroupMemberForCall(
-          receiver, selectorLookupClass, data->receiverIsClass, entry, count);
+      NativeApiSelectorGroupCallTarget callTarget =
+          selectorGroupCallTargetForEntry(receiver, selectorLookupClass,
+                                          data->receiverIsClass, entry, count);
       selectorNamePtr = callTarget.selectorName;
       selectedMember = callTarget.member;
       callTargetCanPrepare = callTarget.canPrepare;

benchmarks/objc-dispatch/objc-dispatch-benchmarks.js

@@ -109,6 +109,26 @@
       return i;
     });
 
+    if (globalThis.performance && typeof globalThis.performance.now === "function") {
+      var performanceNow = globalThis.performance.now;
+      function NativePrototypeCall() {}
+      NativePrototypeCall.prototype.nativeCall = performanceNow;
+      var nativePrototypeCall = new NativePrototypeCall();
+
+      addCase(cases, "js.nativeFunction.performance.now", 1, function () {
+        return performanceNow();
+      });
+
+      addCase(
+        cases,
+        "js.prototype.nativeFunction.performance.now",
+        1,
+        function () {
+          return nativePrototypeCall.nativeCall();
+        }
+      );
+    }
+
     addCase(cases, "NSObject.respondsToSelector", 1, function () {
       return object.respondsToSelector("description");
     });