Fix crash report filtering logic and update crash detection condition

DjDeveloperr · DjDeveloperr · commit 9bd83e3c4af0 · 2026-03-06T17:17:46.000-05:00
diff --git a/scripts/run-tests-macos.js b/scripts/run-tests-macos.js
@@ -245,7 +245,7 @@ function readRecentCrashReportForPid(pid, launchedAtMs) {
     }
 
     const candidates = fs.readdirSync(crashReportsDir)
-        .filter((name) => name.startsWith("TestRunner-") && (name.endsWith(".ips") || name.endsWith(".crash")))
+        .filter((name) => name.startsWith("TestRunner") && (name.endsWith(".ips") || name.endsWith(".crash")))
         .map((name) => {
             const fullPath = path.join(crashReportsDir, name);
             let stats;
@@ -676,7 +676,7 @@ function main() {
         const exitStatus = getProcessExitStatus(code, signal);
 
         if (!completedSuccessfully) {
-            if (isLikelyCrash(code, signal)) {
+            if (code !== 0 || signal) {
                 await emitCrashBacktrace(appBinaryPath, runArgs, launchedAtMs, childPid);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ function readRecentCrashReportForPid(pid, launchedAtMs) {`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`const candidates = fs.readdirSync(crashReportsDir)`
`248`		`- .filter((name) => name.startsWith("TestRunner-") && (name.endsWith(".ips") \|\| name.endsWith(".crash")))`
	`248`	`+ .filter((name) => name.startsWith("TestRunner") && (name.endsWith(".ips") \|\| name.endsWith(".crash")))`
`249`	`249`	`.map((name) => {`
`250`	`250`	`const fullPath = path.join(crashReportsDir, name);`
`251`	`251`	`let stats;`
`@@ -676,7 +676,7 @@ function main() {`
`676`	`676`	`const exitStatus = getProcessExitStatus(code, signal);`
`677`	`677`
`678`	`678`	`if (!completedSuccessfully) {`
`679`		`- if (isLikelyCrash(code, signal)) {`
	`679`	`+ if (code !== 0 \|\| signal) {`
`680`	`680`	`await emitCrashBacktrace(appBinaryPath, runArgs, launchedAtMs, childPid);`
`681`	`681`	`}`
`682`	`682`