clean up

Author: shirakaba

NativeScript/CMakeLists.txt

@@ -54,10 +54,10 @@ elseif(TARGET_PLATFORM STREQUAL "macos")
   set(TARGET_PLATFORM_SPEC "macos-arm64_x86_64")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DTARGET_PLATFORM_MACOS")
 
-# Force dSYM generation for macOS (by default, they're embedded into the
-# binary itself, giving us a 14,981,336 byte / 15 MB binary)
-# set(CMAKE_XCODE_ATTRIBUTE_DEBUG_INFORMATION_FORMAT "dwarf-with-dsym")
-# set(CMAKE_XCODE_ATTRIBUTE_DWARF_DSYM_FOLDER_PATH "${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>")
+  # Unlike "ios", "macos" doesn't seem to produce a NativeScript.framework.dSYM
+  # by default. We can produce it by setting these variables.
+  set(CMAKE_XCODE_ATTRIBUTE_DEBUG_INFORMATION_FORMAT "dwarf-with-dsym")
+  set(CMAKE_XCODE_ATTRIBUTE_DWARF_DSYM_FOLDER_PATH "${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>")
 else()
   message(FATAL_ERROR "Unknown target platform: ${TARGET_PLATFORM}")
   return()

build_all_react_native.sh

@@ -1,21 +1,3 @@
 #!/bin/bash
 
-# Remember to run:
-#
-# $ npm run metagen ios-sim
-# metadata-generator/metadata/metadata.ios-sim.arm64.h
-# metadata-generator/metadata/metadata.ios-sim.arm64.nsmd
-# metadata-generator/metadata/metadata.ios-sim.x86_64.h
-# metadata-generator/metadata/metadata.ios-sim.x86_64.nsmd
-#
-# $ npm run metagen ios
-# metadata-generator/metadata/metadata.ios.arm64.h
-# metadata-generator/metadata/metadata.ios.arm64.nsmd
-#
-# $ npm run metagen macos
-# metadata-generator/metadata/metadata.macos.arm64.h
-# metadata-generator/metadata/metadata.macos.arm64.nsmd
-# metadata-generator/metadata/metadata.macos.x86_64.h
-# metadata-generator/metadata/metadata.macos.x86_64.nsmd
-
 ./build_all_ios.sh --no-engine --embed-metadata --macos

scripts/build_xcframework.mts

@@ -5,6 +5,15 @@ import { createXCframework } from "react-native-node-api";
 
 main();
 
+/**
+ * Builds an XCFramework in the style that `react-native-node-api` expects,
+ * following the [prebuilds standard](https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md).
+ *
+ * This is really just an XCFramework renamed with a `.node` extension,
+ * containing an extra file named `react-native-api-module`. Once `cmake-rn`
+ * supports it, we may be able to replace this whole script with a simple
+ * `cmake-rn` call.
+ */
 async function main() {
   const __dirname = import.meta.dirname;
   if (!__dirname) {
@@ -13,6 +22,8 @@ async function main() {
 
   const monorepoRoot = path.resolve(__dirname, "..");
 
+  // Args are designed to match the names of the args from cmake we're
+  // interested in.
   const args = yargsParser(process.argv.slice(2), {
     configuration: {
       "short-option-groups": false,