fix: improve resource cleanup in N-API environment and runtime

- Added checks to ensure valid arguments in `js_free_napi_env` and `js_free_runtime` functions, enhancing error handling.
- Implemented a locker mechanism to prevent unmatched isolate entries during runtime disposal, ensuring proper resource management.
- Adjusted the destructor in `Runtime` to handle module deinitialization more gracefully, maintaining consistency in cleanup operations.

Author: DjDeveloperr

NativeScript/napi/v8/jsr.cpp

@@ -161,13 +161,25 @@ napi_status js_create_napi_env(napi_env* env, napi_runtime runtime) {
 
 napi_status js_free_napi_env(napi_env env) {
     if (env == nullptr) return napi_invalid_arg;
+    JSR::env_to_jsr_cache.erase(env);
     env->DeleteMe();
     return  napi_ok;
 }
 
 napi_status js_free_runtime(napi_runtime runtime) {
+    if (runtime == nullptr) return napi_invalid_arg;
     JSR* jsr = (JSR*) runtime;
+    if (jsr == nullptr || jsr->isolate == nullptr) return napi_invalid_arg;
+
+    // Ensure there are no outstanding current-thread isolate entries when
+    // disposing. This protects teardown from accidental unmatched enters.
+    v8::Locker locker(jsr->isolate);
+    while (v8::Isolate::GetCurrent() == jsr->isolate) {
+        jsr->isolate->Exit();
+    }
+
     jsr->isolate->Dispose();
+    jsr->isolate = nullptr;
     delete jsr;
     return napi_ok;
 }

NativeScript/runtime/Runtime.cpp

@@ -40,17 +40,21 @@ Runtime::Runtime() {
 Runtime::~Runtime() {
   currentRuntime_ = nullptr;
 
-  modules_.DeInit();
-
   if (env_) {
-     {
-       NapiScope scope(env_);
-
-       napi_close_handle_scope(env_, globalScope_);
-       js_free_napi_env(env_);
-     }
+    {
+      // Enter isolate/context for deinit work without creating another
+      // temporary N-API handle scope. We must close the long-lived
+      // `globalScope_` in LIFO order.
+      NapiScope scope(env_, false);
+
+      modules_.DeInit();
+      napi_close_handle_scope(env_, globalScope_);
+      js_free_napi_env(env_);
+    }
 
     js_free_runtime(runtime_);
+  } else {
+    modules_.DeInit();
   }
 
   {