Skip to content

Commit 8d71292

Browse files
GitHub Actions workflow fixes (#844)
* GitHub Actions workflow fixes - Fix CodeQL query pack. - Fix shellcheck warning. - Do not fail all CI jobs if one fails. Contributes to #814. * Fix concurrency Include the matrix node version in the group name.
1 parent 784a044 commit 8d71292

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/codeql.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ jobs:
4141
uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
4242
with:
4343
languages: ${{ matrix.language }}
44-
queries: security
4544

4645
- name: Perform CodeQL Analysis
4746
uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2

.github/workflows/node.js.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ jobs:
1515
timeout-minutes: 10
1616

1717
concurrency:
18-
group: ${{ github.workflow }}-${{ github.sha }}
18+
group: ${{ github.workflow }}-${{ github.sha }}-${{ matrix.node-version }}
1919
cancel-in-progress: false
2020

2121
permissions:
2222
contents: read
2323

2424
strategy:
25+
fail-fast: false
2526
matrix:
2627
node-version: [14.x, 16.x, 18.x, 20.x, 22.x]
2728

@@ -38,7 +39,7 @@ jobs:
3839
package-manager-cache: false
3940

4041
- name: Set PUBLISH_PLEASE_DISABLE_PROMPT
41-
run: echo "PUBLISH_PLEASE_DISABLE_PROMPT=true" >> $GITHUB_ENV
42+
run: echo "PUBLISH_PLEASE_DISABLE_PROMPT=true" >> "${GITHUB_ENV}"
4243

4344
- name: Install dependencies
4445
run: npm install --ignore-scripts

0 commit comments

Comments
 (0)