fix: stop node namespace prefix parameter ordering in readStopNodeData#818
Open
iruizsalinas wants to merge 1 commit intoNaturalIntelligence:masterfrom
Open
fix: stop node namespace prefix parameter ordering in readStopNodeData#818iruizsalinas wants to merge 1 commit intoNaturalIntelligence:masterfrom
iruizsalinas wants to merge 1 commit intoNaturalIntelligence:masterfrom
Conversation
Member
|
Thanks for your effort and time. Let me test it with some tests and then I'll check the PR. Probably on coming monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Fix incorrect parameter ordering in
readStopNodeDatathat breaks stop node tracking when the tag has a namespace prefix.Type
readStopNodeDatacallsreadTagExp(xmlData, i, '>')at line 760, but'>'ends up in theremoveNSPrefixparameter instead ofclosingChar. Since it's truthy, namespace prefixes get stripped from opening tags inside the stop node, while closing tags keep them. This throws offopenTagCountbecause opens and closes no longer match.The fix is changing
readTagExp(xmlData, i, '>')toreadTagExp(xmlData, i, false)sinceclosingCharalready defaults to">".