Skip to content

Commit e3ab7ee

Browse files
review comments
Signed-off-by: Matt Richerson <matthew.richerson@hpe.com>
1 parent 0c135ed commit e3ab7ee

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

docs/guides/redundant-allocations/readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ If an XFS or Raw allocation is made with `create_persistent`, then the rebuild c
2727

2828
### Zpool
2929

30-
For Lustre allocations using zpool, there are no restrictions on when rebuild commands can be used. The RAID can be rebuilt for job and persistent instances regardless of whether the compute nodes have the file system mounted.
30+
For Lustre allocations using zpool, there are no restrictions on when rebuild commands can be used. The RAID can be rebuilt for job and persistent instances regardless of whether the compute nodes have the file system mounted. This is possible because the Lustre targets are only mounted on the Rabbits.
3131

3232
### Replacing a Drive
3333

34-
If a drive has failed and needs to be replaced, the Rabbit-p and Rabbit-s should be powered off to replace the drive. After powering the Rabbit back on, the `nnf-node-manager` pod will restart on the Rabbit. On initialization, Rabbit software will find the new drive and add an NVMe namespace for each allocation. If the rebuild commands have been specified, the Rabbit software will run them to add the new NVMe namespace into the RAID device.
34+
If a drive fails and must be replaced, the Rabbit-p and Rabbit-s should be powered off to replace the drive. After replacing the drive and powering the Rabbit back on, the `nnf-node-manager` pod restarts on the Rabbit. On initialization, Rabbit software locates the new drive and adds an NVMe namespace for each allocation. If rebuild commands have been specified, the Rabbit software will run them to add the new NVMe namespace into the RAID device and restore the correct data.
3535

3636
## Allocation Status
3737

docs/guides/storage-profiles/readme.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,11 @@ In general, `scale` gives a simple way for users to get a filesystem that has pe
288288

289289
### RAID Configurations
290290

291-
Allocations can be set up to use a RAID device to provide redundancy in the event of a drive failure. Optionally, commands can be specified to rebuild the RAID device after a replacement drive has been added. The storage profile parameters differ depending on whether the allocation is using LVM or zpool.
291+
Allocations can be set up to use a RAID device to provide continued access in the event of a drive failure. Optionally, commands can be specified to rebuild the RAID device after a replacement drive has been added. The storage profile parameters differ depending on whether the allocation is using LVM or zpool.
292292

293293
#### Zpool
294294

295-
To create a Lustre confiuration with a redundant zpool, the `raidz` option should be added to the `zpoolCreate` command. To allow the zpool to be rebuilt with a new drive, the `zpoolReplace` command should be included.
295+
To create a Lustre confiuration with a redundant zpool, the `raidz` option is required in `zpoolCreate` command. To allow the zpool to be rebuilt with a new drive, the `zpoolReplace` command is required.
296296

297297
The example below shows a RAID configuration for the OST, however, the same options can be specified for any of the Lustre targets.
298298

@@ -318,11 +318,12 @@ data:
318318

319319
#### LVM
320320

321-
A RAID logical volume can be used with XFS and Raw allocations. gfs2 allocations can not use RAID logical volumes because the LV is shared.
321+
A RAID logical volume can be used with XFS and Raw allocations.
322+
NOTE: gfs2 allocations cannot use RAID logical volumes because the LV is shared.
322323

323324
To create a redundant LV, `--type raid[x]` and `--nosync` should be specified in the `lvcreate` command. Also, the `--stripes` parameter should be adjusted accordingly to specify the number of data stripes. For `raid5`, `$DEVICE_NUM-1` is used.
324325

325-
To allow the LV to be rebuilt after a replacement drive is added, `vgExtend`, `lvRepair`, and `vgReduce` should be specified in the `lvmRebuild` section.
326+
To allow the LV to rebuild after a drive is replaced, `vgExtend`, `lvRepair`, and `vgReduce` should be specified in the `lvmRebuild` section.
326327

327328
```yaml
328329
apiVersion: nnf.cray.hpe.com/v1alpha8

0 commit comments

Comments
 (0)