Add NnfContainerData documentation - #307
Merged
Merged
Conversation
Document the NnfContainerData resource that is created during PreRun for external container orchestrators to use. Signed-off-by: Matt Richerson <matthew.richerson@hpe.com>
ajfloeder
reviewed
Mar 12, 2026
| the workflow. In turn, user containers are created and launched by Kubernetes. Containers are | ||
| expected to start in this state. If `createContainer: false`, no pods are launched; instead an | ||
| [`NnfContainerData`](#nnfcontainerdata) resource is created that records the storage mount paths. | ||
| - PostRun: If `createContainer: true`, user containers are expected to complete (non-zero exit) |
Contributor
There was a problem hiding this comment.
(non-zero exit) would indicate the container failed, wouldn't it?
ajfloeder
reviewed
Mar 12, 2026
| | `data.volumes[].mountPath` | string | Absolute path on the Rabbit node where the storage is mounted | | ||
|
|
||
| The external orchestrator can query the resource by workflow name and namespace to discover where | ||
| each storage volume is mounted: |
Contributor
There was a problem hiding this comment.
Suggested change
| each storage volume is mounted: | |
| each storage volume is mounted. |
Signed-off-by: Matt Richerson <matthew.richerson@hpe.com>
ajfloeder
approved these changes
Mar 12, 2026
github-project-automation
Bot
moved this from 📋 Open
to 👀 In review
in Issues Dashboard
github-project-automation
Bot
moved this from 👀 In review
to ✅ Closed
in Issues Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the NnfContainerData resource that is created during PreRun for external container orchestrators to use.