Fix nnf_cmd exit code and update submodule pointers - #323
Merged
Conversation
Preserve the exit code of release-all.sh through the pipe in nnf_cmd by returning PIPESTATUS[0]. Previously, all invocations exited 0 because the pipe's exit code was that of 'cat', not release-all.sh. Also advance submodule pointers to their current master HEADs: - lustre-fs-operator: 7ebec7d -> c59379b (PR #125 update-vendor) - nnf-dm: 42a3d3a4 -> c959e3b5 (PR #360 update-vendor + others) - nnf-integration-test: b967cc0 -> 3e52df1 (PR #160 update-vendor + #159) - nnf-sos: 8749851d -> bcb00b92 (PR #604 update-vendor + others) Also restore the ONE-command-per-turn rule to release.agent.md and remove trailing blank lines from RELEASE-PLAN.md. Signed-off-by: Anthony Floeder <anthony.floeder@hpe.com>
ajfloeder
requested review from
bdevcich,
matthew-richerson and
roehrich-hpe
as code owners
April 9, 2026 17:03
matthew-richerson
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the exit code of
release-all.shthrough the pipe innnf_cmdby capturingpipestatus[1](zsh) before returning. Previously, all invocations exited 0 because the pipe's exit code was that ofcat, notrelease-all.sh.Also adds a note to RELEASE-PLAN.md that
source setup-release-env.shmust never be piped — doing so runs it in a subshell and loses all exported variables and function definitions.Also advances submodule pointers to their current master HEADs:
lustre-fs-operator: 7ebec7d -> c59379b (PR Add chassis1 to the configuration #125 update-vendor)nnf-dm: 42a3d3a4 -> c959e3b5 (PR #360 update-vendor + others)nnf-integration-test: b967cc0 -> 3e52df1 (PR Set audit policy level to metadata #160 update-vendor + Update submodules #159)nnf-sos: 8749851d -> bcb00b92 (PR #604 update-vendor + others)Also restores the ONE-command-per-turn rule to
release.agent.mdand removes trailing blank lines fromRELEASE-PLAN.md.