Skip to content

Fix nnf_cmd exit code and update submodule pointers #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajfloeder merged 1 commit into from
Apr 9, 2026
Merged

Fix nnf_cmd exit code and update submodule pointers #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/agents/release.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Before starting any release work, read these files completely:
## Core Rules

- **ALWAYS wait for explicit user approval before proceeding to the next step.** After every step, state what you did, whether it succeeded, and the evidence. **WAIT for the user.**
- **ONE command per turn.** Run the command for ONE repo, show the full output, state PASS or FAIL with evidence, then STOP. Do not run the next repo's command until the user explicitly says to proceed. This applies even when the plan shows a `for` loop — execute the loop body manually, one repo per turn.
- **ALWAYS run commands in a terminal** so the user can see them.
- **ALWAYS append `2>&1 | cat`** to every `release-all.sh` and `gh` command — no exceptions.
- **ONE repo at a time.** Execute one phase per repo sequentially. **NEVER parallelize** across repos.
Expand Down
2 changes: 1 addition & 1 deletion lustre-fs-operator
Open in desktop
Submodule lustre-fs-operator updated 3 files
+1 −1 go.mod
+2 −2 go.sum
+1 −1 vendor/modules.txt
2 changes: 1 addition & 1 deletion nnf-dm
Open in desktop
Submodule nnf-dm updated 135 files
2 changes: 1 addition & 1 deletion nnf-integration-test
Open in desktop
Submodule nnf-integration-test updated 3 files
+3 −3 go.mod
+6 −6 go.sum
+7 −0 int_test.go
2 changes: 1 addition & 1 deletion nnf-sos
Open in desktop
Submodule nnf-sos updated 11 files
+7 −3 api/v1alpha10/conversion.go
+7 −3 api/v1alpha9/conversion.go
+2 −2 go.mod
+4 −4 go.sum
+6 −2 internal/controller/nnf_clientmount_controller.go
+2 −2 internal/controller/nnf_workflow_controller.go
+2 −2 internal/controller/nnf_workflow_controller_helpers.go
+2 −2 internal/controller/nnf_workflow_controller_test.go
+229 −0 scripts/compute_refresh.sh
+622 −0 scripts/rabbit_wipe.sh
+2 −2 vendor/modules.txt
4 changes: 2 additions & 2 deletions tools/release-all/RELEASE-PLAN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ Source the release environment helper to auto-compute versions, detect the relea
source ./setup-release-env.sh -B patch # or -B minor / -B major
```

> **Important:** Never pipe this `source` command (e.g. `source ... | cat`). Piping runs `source` in a subshell, which means the exported variables and function definitions (`nnf_cmd`, etc.) are lost to the calling shell. If you need to capture output, redirect to a file or run without the pipe.

This exports `$PREVIOUS_RELEASE`, `$NNF_RELEASE`, `$RELEASE_TYPE`, and `$RELEASE_REVIEWERS`, and defines helper functions `nnf_cmd`, `nnf_create_pr`, `nnf_add_reviewers`, and `nnf_gh_repo`. Confirm the printed summary with the user before proceeding.

List repos:
Expand Down Expand Up @@ -270,8 +272,6 @@ The `-i` flag displays image version changes inline. Use `-d` to display the ful

Check each repo for correct tag, release notes, and artifacts (`manifests.tar` + `manifests-kind.tar` on `nnf-deploy`).



---

### Relevant files
Expand Down
5 changes: 4 additions & 1 deletion tools/release-all/setup-release-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,12 @@ fi
# Usage: nnf_cmd <phase> <repo>
nnf_cmd() {
local phase="$1" repo="$2"
local args=()
local args=() _rc
[[ "$repo" == "nnf_sos" ]] && args+=("-M")
./release-all.sh -B "$RELEASE_TYPE" -P "$phase" -R "$repo" "${args[@]}" 2>&1 | cat
# bash uses PIPESTATUS[0]; zsh uses pipestatus[1] (lowercase, 1-indexed)
_rc=${PIPESTATUS[0]:-${pipestatus[1]}}
return "${_rc:-0}"
}

# --- Helper: create-pr + capture PR number -----------------------------------
Expand Down
Loading