Handle helm chart releases - #330
Conversation
The lustre-csi-driver repo has support for helm charts that are setup to allow github to serve as a chart repo. This chart is expected to be in the master branch. The release-all tool will create a "chart-releases/" directory in the release branch and copy that chart into it and munge it with proper release info. This allows github to serve as a chart repo for the release branch's chart as well. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
| local indent="$3" | ||
|
|
||
| msg "${indent}Verifying clean build on GitHub for $default_branch..." | ||
| build_status=$(gh run list --repo "$repo_url" --branch "$default_branch" --limit 1 --json conclusion -q '.[0].conclusion' 2>/dev/null || echo "unknown") |
There was a problem hiding this comment.
consider also checking the status field in case conclusion is null.
There was a problem hiding this comment.
Have you found something that indicates that can happen? If it's null, it'll be caught on the next line. I'd like to stop there and understand how it could be null.
There was a problem hiding this comment.
conclusion : null if status: in_progress for running workflows. A nicer error message would be helpful to the admin.
There was a problem hiding this comment.
A running workflow looks like this:
$ GH_HOST=github.hpe.com gh run list --json conclusion -q '.[1] | {"status":.status,"conclusion":.conclusion}'
{
"conclusion": "",
"status": null
}
So conclusion is not "null", but empty string. And status is not "in_progress", it's the word "null".
Let me fuss with that.
There was a problem hiding this comment.
Ah, I did that wrong. It is more informative:
gh run list --json status,conclusion -q '.[0] | {"status":.status,"conclusion":.conclusion}'
{
"conclusion": "",
"status": "in_progress"
}
|
Take another look here, please. |
|
Don't you need the latest |
Yes, thanks for the reminder. |
3 participants
The lustre-csi-driver repo has support for helm charts that are setup to allow github to serve as a chart repo. This chart is expected to be in the master branch.
The release-all tool will create a "chart-releases/" directory in the release branch and copy that chart into it and munge it with proper release info. This allows github to serve as a chart repo for the release branch's chart as well.