Fix dependabot security vulnerabilities - #152
Merged
Merged
Conversation
Signed-off-by: Anthony Floeder <anthony.floeder@hpe.com>
matthew-richerson
approved these changes
Mar 10, 2026
roehrich-hpe
approved these changes
Mar 10, 2026
|
|
||
| if !strings.HasPrefix(rsp, "success") { | ||
| return fmt.Errorf(strings.TrimRight(rsp, "\n")) | ||
| return fmt.Errorf("%s", strings.TrimRight(rsp, "\n")) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("%s", strings.TrimRight(rsp, "\n")) | |
| return errors.New(strings.TrimRight(rsp, "\n") |
eh?
Contributor
Author
There was a problem hiding this comment.
You are suggesting returning to the version that go vet rejected. Going with the new version.
Contributor
There was a problem hiding this comment.
The version you have is fine.
But, let me clarify my intent.
Vet was probably complaining about fmt.Errorf() because it didn't include the "%s". Because Errorf has f.
The errors.New() would let you use the strings.TrimRight(rsp, "\n") without needing the "%s". Because errors.New() doesn't have the f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all resolvable dependency vulnerabilities identified by
govulncheck.Dependency Updates
github.com/golang/gloggithub.com/sirupsen/logrusk8s.io/mount-utilsgolang.org/x/netgolang.org/x/sysgolang.org/x/textgolang.org/x/toolsOther Changes
golang:1.23togolang:1.25.7go 1.25.7fmt.Errorfcalls with non-constant format strings (Go vet compliance)debugPrintfcall missing thedevIDargument for%dverbRemaining Stdlib Vulnerabilities (require go1.25.8)
These cannot be fixed without upgrading the Go toolchain:
html/templateosnet/url