Skip to content

Commit 23752f2

Browse files
committed
Step.7 monitor-updates: form-default fixes - critical_elapsed_days 7->3 + updateRing ''
Two form-default cleanups in the Step.7 YAML templates (GH Actions + ADO): 1. critical_elapsed_days default 7 -> 3 The v0.7.99 release lowered the CRITICAL overall-elapsed tier from 7 to 3 days. The inline script default was updated correctly ($criticalElapsedDays = 3) and the help-text reads "default 3 days", but the workflow_dispatch / pipeline-parameter default value was left at '7'. When an operator leaves the input untouched the form-default '7' is non-empty, so the override path runs and silently restores the old threshold. 2. updateRing default 'Wave1' -> '' (empty) Matches Step.8 + Step.9 which already use default: ''. The downstream guard `if ($scope -eq 'by-update-ring' -and $updateRing)` honours empty as "no filter", so behaviour is unchanged for the default scope='all' path. Removes the misleading "Wave1" value that suggested a real default exists when the operator switches to scope=by-update-ring. Files changed: Automation-Pipeline-Examples/github-actions/Step.7_monitor-updates.yml Automation-Pipeline-Examples/azure-devops/Step.7_monitor-updates.yml
1 parent c490d26 commit 23752f2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

AzLocal.UpdateManagement/Automation-Pipeline-Examples/azure-devops/Step.7_monitor-updates.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ parameters:
5555
# accepts single ring, 'Prod;Ring2' list, or '***' wildcard (three stars - deliberate).
5656
displayName: "UpdateRing tag value (only used when scope=by-update-ring). Single, 'Prod;Ring2', or '***'."
5757
type: string
58-
default: 'Wave1'
58+
default: ''
5959

6060
- name: longRunningStepHours
6161
displayName: 'PRIMARY signal (v0.7.96+). Flag in-flight runs whose CURRENT STEP has been running longer than this many hours.'
@@ -75,7 +75,7 @@ parameters:
7575
- name: criticalElapsedDays
7676
displayName: 'CRITICAL tier for overall-elapsed (v0.7.99+, default 3 days). Runs older than this get a :rotating_light: chip; older than 2x get a :skull: chip - strongest visual signal that human intervention is needed.'
7777
type: string
78-
default: '7'
78+
default: '3'
7979

8080
- name: moduleVersion
8181
displayName: 'Pin AzLocal.UpdateManagement version (empty = latest from PSGallery). See Automation-Pipeline-Examples/README.md section 5 "Optional configuration".'

AzLocal.UpdateManagement/Automation-Pipeline-Examples/github-actions/Step.7_monitor-updates.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ on:
5858
# or '***' (three stars - deliberate, not a typo) to match every cluster that HAS the UpdateRing tag set.
5959
description: "UpdateRing tag value (only used when scope=by-update-ring). Single ring, 'Prod;Ring2', or '***'."
6060
required: false
61-
default: 'Wave1'
61+
default: ''
6262
long_running_step_hours:
6363
description: 'PRIMARY signal (v0.7.96+). Flag in-flight runs whose CURRENT STEP has been running longer than this many hours (default 2). More accurate than overall-run elapsed for large clusters where a legitimate 12-node run can exceed 6-8h while each individual step ticks along normally.'
6464
required: false
@@ -74,7 +74,7 @@ on:
7474
critical_elapsed_days:
7575
description: 'CRITICAL tier for overall-elapsed (v0.7.99+, default 3 days). In-flight runs older than this get a :rotating_light: chip; older than 2x this get a :skull: chip. Strongest visual signal that human intervention is needed - a 19-day-stuck run will no longer be hidden behind a single "step errored" chip.'
7676
required: false
77-
default: '7'
77+
default: '3'
7878
module_version:
7979
description: 'Pin AzLocal.UpdateManagement version (empty = latest from PSGallery). See Automation-Pipeline-Examples/README.md section 5 "Optional configuration".'
8080
required: false

0 commit comments

Comments
 (0)