Skip to content

Change == to error by default (instead of returning false) when comparing elements for which no equality test has been implemented #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgoettgens wants to merge 5 commits into
base: master
Choose a base branch
from
+5 −0
Open

Change == to error by default (instead of returning false) when comparing elements for which no equality test has been implemented #1853

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32b8ce9
Add generic == error
lgoettgens Oct 9, 2024
aad74a9
Merge branch 'master' into lg/equality-error
lgoettgens Oct 9, 2024
ad2fa43
Apply suggestions from code review
fingolfin Dec 23, 2025
f2b8a7d
Apply suggestions from code review
fingolfin Feb 3, 2026
2b2576c
Apply suggestion from @fingolfin
fingolfin Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/fundamental_interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
#
###############################################################################

function Base.:(==)(x::AbstractAlgebra.SetElem, y::AbstractAlgebra.SetElem)
x === y && return true
Copy link
Copy Markdown
Member

@fingolfin fingolfin Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now just added this, to get the tests to run; but this is not meant to preempt any discussion, i.e., we can still remove it again, but I wanted to at least know if with this the OscarCI etc. tests complete or (still) don't.

throw(NotImplementedError(:(==), x, y))
end

###############################################################################
#
# Parents, elements and data type methods
Expand Down
Loading