Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2253 +/- ##
==========================================
- Coverage 88.24% 88.23% -0.01%
==========================================
Files 126 126
Lines 31817 31817
==========================================
- Hits 28076 28075 -1
- Misses 3741 3742 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Please do another patch release first, then bump the version to 0.48.0-DEV. And then we can start merging some of these breaking PRs. |
Member
Forget the patch release. Some PRs marked as breaking are already merged. |
Member
|
This now just needs the changelog to be updated. |
lgoettgens
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Nemocas/AbstractAlgebra.jl/milestone/1.
I'd like to make another breaking AA release soon (perhaps even this week?). PRs that would be nice to get in (could be revised):
PolyRing(R)andpolynomial_ring_only(and deprecate both) by calls to newpoly_ringhelper #1729residue_ringfor zero rings for technical reasons #1857transposeandtranspose!methods, restrict in-placetranspose!to square matrices #1937relsandrelations#2168_upgradeand_add_gensfor mpolys #2198==(x::NCRingElem, y::NCRingElem)fallback #2212FracFieldisRingElem, notRingElement#2251subandgetindexfor submatrices #2252^(I::Ideal, k::Integer)fallback method #2279I also set up a milestone for this https://github.com/Nemocas/AbstractAlgebra.jl/milestone/1 -- this allows filtering PRs (and issues) by milestone.