Skip to content

Disallow nondistinct variable names for universal rings#2413

Merged
fingolfin merged 1 commit into
Nemocas:masterfrom
SoongNoonien:uring_var_names
Jun 3, 2026
Merged

Disallow nondistinct variable names for universal rings#2413
fingolfin merged 1 commit into
Nemocas:masterfrom
SoongNoonien:uring_var_names

Conversation

@SoongNoonien

Copy link
Copy Markdown
Collaborator

This is the first step in the direction of #2408.

@SoongNoonien SoongNoonien added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label May 27, 2026
@SoongNoonien

Copy link
Copy Markdown
Collaborator Author

I'm not sure if this should be tagged "breaking". While it technically is breaking, it shouldn't have been possible in the first place to create a universal ring with duplicate variable names.

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (2657ac7) to head (5875ae8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
- Coverage   88.13%   88.12%   -0.01%     
==========================================
  Files         130      130              
  Lines       32948    32949       +1     
==========================================
- Hits        29038    29037       -1     
- Misses       3910     3912       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin

Copy link
Copy Markdown
Member

@fieker is requesting a new interface akin to add_vars(UnivR, num) which adds num new variables to a universal ring, and returns them. I.e., it takes care of choosing admissible names.

I think this can be done in a follow-up PR.

@fingolfin

Copy link
Copy Markdown
Member

Regarding the breaking label: I'd be fine with just merging this, as long as it doesn't break our upstream tests. If it breaks something for another user, I am sorry, but most likely there already were issues in their code. If someone is affected by this and reads this: sorry! but please get in touch with us, then we can make sure next time we are aware of your needs and take them into account.

@fingolfin
fingolfin merged commit 4fc6ae2 into Nemocas:master Jun 3, 2026
24 of 26 checks passed
@thofma thofma added enhancement New feature or request and removed triage labels Jun 8, 2026
thofma referenced this pull request Jun 9, 2026
Co-authored-by: changelog[bot] <changelog[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants