Disallow nondistinct variable names for gens(::UniversalRing, ...)#2449
Merged
Conversation
SoongNoonien
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2449 +/- ##
=======================================
Coverage 88.13% 88.14%
=======================================
Files 129 129
Lines 33017 33019 +2
=======================================
+ Hits 29099 29103 +4
+ Misses 3918 3916 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lgoettgens
changed the title
gensgens(::UniversalRing, ...)
lgoettgens
reviewed
Jul 1, 2026
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, I forgot this in #2413.