Cf/modstd#2172
Open
fieker wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
- Coverage 88.17% 88.10% -0.08%
==========================================
Files 99 99
Lines 37177 37192 +15
==========================================
- Hits 32782 32767 -15
- Misses 4395 4425 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Nov 11, 2025
| d = ZZ() | ||
| a = mod(a, b) | ||
| fl = _ratrec!(n, d, a, b; error_tolerant) | ||
| return fl, n, d |
Member
There was a problem hiding this comment.
Everything below this return is unreachable and should eventually be removed
Contributor
Author
|
On Tue, Nov 11, 2025 at 06:44:17AM -0800, Lars Göttgens wrote:
@lgoettgens commented on this pull request.
> @@ -3093,6 +3108,12 @@ function _rational_reconstruction(a::ZZRingElem, b::ZZRingElem; error_tolerant::
fl = _ratrec!(n, d, a, b)
return fl, n, d
elseif error_tolerant
+ n = ZZ()
+ d = ZZ()
+ a = mod(a, b)
+ fl = _ratrec!(n, d, a, b; error_tolerant)
+ return fl, n, d
Everything below this `return` is unreachable and should eventually be removed
eventually... there is also a new issue in flint to discuss the legality
of this approach...
cf flintlib/flint#2488
… --
Reply to this email directly or view it on GitHub:
#2172 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Member
|
What's the status of this PR, @fieker ? |
Contributor
Author
|
No change: it works, but depends on undocumented internals. A corresponding questi in flint is unanswered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.