Skip to content

Patched _solve_triu and _solve_tril; beefed up the tests#2177

Merged
JohnAAbbott merged 2 commits into
Nemocas:masterfrom
JohnAAbbott:JAA/PATCH-solve_triu
Mar 4, 2026
Merged

Patched _solve_triu and _solve_tril; beefed up the tests#2177
JohnAAbbott merged 2 commits into
Nemocas:masterfrom
JohnAAbbott:JAA/PATCH-solve_triu

Conversation

@JohnAAbbott
Copy link
Copy Markdown
Collaborator

The patches change just 2 lines, but I renamed the args to _solve_tril! so that they correspond to the "doc" in the comment right before the function (and also coherent with _solve_triu). The tests are now with 3x3 matrices since the old buggy code happened to work with 2x2 matrices.

@JohnAAbbott
Copy link
Copy Markdown
Collaborator Author

I note that currently the documentation for _solve_triu is in AbstractAlgebra; in particular near line 3498 in the file src/Matrix.jl there is the following:

# Remove the following once Nemo is adjusted
_solve_triu_right(M, b; unipotent = false) = _solve_triu(M, b; unipotent, side = :right)

There is apparently no documentation for _solve_tril!

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.60%. Comparing base (222f2e1) to head (95f986c).
⚠️ Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz_mat.jl 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   88.17%   89.60%   +1.43%     
==========================================
  Files          99      100       +1     
  Lines       37181    48324   +11143     
==========================================
+ Hits        32786    43303   +10517     
- Misses       4395     5021     +626     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnAAbbott JohnAAbbott marked this pull request as ready for review January 15, 2026 14:54
@JohnAAbbott
Copy link
Copy Markdown
Collaborator Author

Not sure why this was still a draft -- now changed to standard PR.

@fingolfin
Copy link
Copy Markdown
Member

Maybe @JohnAAbbott and @fieker can look into this in the afternoon to get it over the finish line. Also PR #2152

@JohnAAbbott JohnAAbbott added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Mar 4, 2026
@JohnAAbbott JohnAAbbott merged commit 8a288a1 into Nemocas:master Mar 4, 2026
38 of 40 checks passed
@JohnAAbbott JohnAAbbott deleted the JAA/PATCH-solve_triu branch March 4, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants