Patched _solve_triu and _solve_tril; beefed up the tests#2177
Merged
Conversation
Collaborator
Author
|
I note that currently the documentation for There is apparently no documentation for |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
+ Coverage 88.17% 89.60% +1.43%
==========================================
Files 99 100 +1
Lines 37181 48324 +11143
==========================================
+ Hits 32786 43303 +10517
- Misses 4395 5021 +626 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Not sure why this was still a draft -- now changed to standard PR. |
Member
|
Maybe @JohnAAbbott and @fieker can look into this in the afternoon to get it over the finish line. Also PR #2152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patches change just 2 lines, but I renamed the args to
_solve_tril!so that they correspond to the "doc" in the comment right before the function (and also coherent with_solve_triu). The tests are now with 3x3 matrices since the old buggy code happened to work with 2x2 matrices.