Skip to content

Commit bc29743

Browse files
authored
Merge branch 'main' into main
2 parents 50d01a4 + cf9b4e7 commit bc29743

9 files changed

Lines changed: 451 additions & 220 deletions

File tree

.github/workflows/backend-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757

5858
- name: Upload coverage artifact
5959
if: always()
60-
uses: actions/upload-artifact@v5
60+
uses: actions/upload-artifact@v6
6161
with:
6262
name: backend-coverage
6363
path: backend/coverage.out
@@ -89,7 +89,7 @@ jobs:
8989

9090
- name: Upload coverage artifact
9191
if: always()
92-
uses: actions/upload-artifact@v5
92+
uses: actions/upload-artifact@v6
9393
with:
9494
name: cli-coverage
9595
path: cli/coverage.out

.github/workflows/e2e-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
run: docker save arcane:playwright-tests -o /tmp/arcane-image.tar
5454

5555
- name: Upload Docker image artifact
56-
uses: actions/upload-artifact@v5
56+
uses: actions/upload-artifact@v6
5757
with:
5858
name: arcane-image
5959
path: /tmp/arcane-image.tar
@@ -110,7 +110,7 @@ jobs:
110110
docker network create my-test-network || true
111111
112112
- name: Download Arcane Docker image artifact
113-
uses: actions/download-artifact@v6
113+
uses: actions/download-artifact@v7
114114
with:
115115
name: arcane-image
116116
path: /tmp
@@ -139,7 +139,7 @@ jobs:
139139

140140
- name: Upload Playwright HTML report
141141
if: always()
142-
uses: actions/upload-artifact@v5
142+
uses: actions/upload-artifact@v6
143143
with:
144144
name: playwright-report-${{ matrix.database.name }}
145145
path: tests/.report

.github/workflows/sync-go-workspace.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
go work sync
4040
4141
- name: Commit changes (if any)
42-
uses: stefanzweifel/git-auto-commit-action@v5
42+
uses: stefanzweifel/git-auto-commit-action@v7
4343
with:
4444
commit_message: "chore(deps): Synchronize go.mod files via go work sync"
4545
branch: ${{ github.head_ref }}

backend/internal/huma/handlers/environments.go

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
"github.com/getarcaneapp/arcane/backend/internal/services"
1313
"github.com/getarcaneapp/arcane/backend/internal/utils"
1414
"github.com/getarcaneapp/arcane/backend/internal/utils/mapper"
15+
"github.com/getarcaneapp/arcane/backend/internal/utils/pagination"
1516
"go.getarcane.app/types/base"
1617
"go.getarcane.app/types/environment"
1718
)
@@ -39,10 +40,11 @@ type EnvironmentPaginatedResponse struct {
3940
}
4041

4142
type ListEnvironmentsInput struct {
42-
Page int `query:"pagination[page]" default:"1" doc:"Page number"`
43-
Limit int `query:"pagination[limit]" default:"20" doc:"Items per page"`
44-
SortCol string `query:"sort[column]" doc:"Column to sort by"`
45-
SortDir string `query:"sort[direction]" default:"asc" doc:"Sort direction"`
43+
Search string `query:"search" doc:"Search query for filtering by name or API URL"`
44+
Sort string `query:"sort" doc:"Column to sort by"`
45+
Order string `query:"order" default:"asc" doc:"Sort direction (asc or desc)"`
46+
Start int `query:"start" default:"0" doc:"Start index for pagination"`
47+
Limit int `query:"limit" default:"20" doc:"Items per page"`
4648
}
4749

4850
type ListEnvironmentsOutput struct {
@@ -307,7 +309,19 @@ func (h *EnvironmentHandler) ListEnvironments(ctx context.Context, input *ListEn
307309
return nil, huma.Error500InternalServerError("service not available")
308310
}
309311

310-
params := buildPaginationParams(input.Page, input.Limit, input.SortCol, input.SortDir)
312+
params := pagination.QueryParams{
313+
SearchQuery: pagination.SearchQuery{
314+
Search: input.Search,
315+
},
316+
SortParams: pagination.SortParams{
317+
Sort: input.Sort,
318+
Order: pagination.SortOrder(input.Order),
319+
},
320+
PaginationParams: pagination.PaginationParams{
321+
Start: input.Start,
322+
Limit: input.Limit,
323+
},
324+
}
311325

312326
envs, paginationResp, err := h.environmentService.ListEnvironmentsPaginated(ctx, params)
313327
if err != nil {

0 commit comments

Comments
 (0)