Fix Post button vanishing with hide_grok_analyze, plus broken toggles (#4)

The composer's Post button disappeared whenever "Hide Grok analyze buttons"
was on, making posting impossible (#2). BHTRemoveGrokBarButtonItems matched
every UIBarButtonItem with a nil accessibilityLabel: [nil rangeOfString:@"grok"]
.location is 0 (a zeroed NSRange from messaging nil), which is != NSNotFound,
so unlabeled bar buttons — the Post button included — were deleted. Guard for a
non-nil label before matching.

Also replace the over-broad TFNButton didMoveToWindow Grok heuristic (it hid any
unlabeled nav-bar button that had a menu — the Post button is exactly that) with
positive identification: hide only TFNButtons whose primary-action menu contains
a Grok item ("Analyse with Grok" / "Open in Grok").

Other broken toggles:
- restore_follow_button ("No Subscribe button"): drop the unconditional
  -[TUIFollowControl variant] override that returned 32 for every read, which
  hid the Follow button on every tweet. The setVariant: remap already converts
  Subscribe (1) -> Follow (32).
- hidePremiumOffer ("No Twitter Blue prompts"): read the pref instead of a
  hardcoded `return YES` (the toggle was stuck on).
- DisableVODCaptions ("No video captions"): read the key the settings UI writes
  (video_layer_caption) instead of an unexposed dis_VODCaptions (toggle was dead).
- refresh_pill_label: scope the "Tweeted" relabel to the new-posts pill instead
  of overriding every TFNPillControl's text.

Co-authored-by: thea <git@thea.pet>

Author: gingerbeardman

BHTManager.m

@@ -182,7 +182,10 @@ + (BOOL)HideTopics {
     return [[NSUserDefaults standardUserDefaults] boolForKey:@"hide_topics"];
 }
 + (BOOL)DisableVODCaptions {
-    return [[NSUserDefaults standardUserDefaults] boolForKey:@"dis_VODCaptions"];
+    // The settings toggle ("No video captions") writes @"video_layer_caption";
+    // this used to read an unexposed @"dis_VODCaptions" key, so the switch did
+    // nothing. Read the key the UI actually sets.
+    return [[NSUserDefaults standardUserDefaults] boolForKey:@"video_layer_caption"];
 }
 + (BOOL)UndoTweet {
     return [[NSUserDefaults standardUserDefaults] boolForKey:@"undo_tweet"];
@@ -248,7 +251,7 @@ + (BOOL)hideViewCount {
     return [[NSUserDefaults standardUserDefaults] boolForKey:@"hide_view_count"];
 }
 + (BOOL)hidePremiumOffer {
-    return YES;
+    return [[NSUserDefaults standardUserDefaults] boolForKey:@"hide_premium_offer"];
 }
 + (BOOL)hideTrendVideos {
     return [[NSUserDefaults standardUserDefaults] boolForKey:@"hide_trend_videos"];

Tweak.x

@@ -4997,13 +4997,10 @@ static BOOL findAndHideButtonWithAccessibilityId(UIView *viewToSearch, NSString
     }
 }
 
-// This hook makes the control ALWAYS REPORT its variant as 32
-- (NSUInteger)variant {
-    if ([BHTManager restoreFollowButton]) {
-        return 32;
-    }
-    return %orig;
-}
+// NOTE: We intentionally do NOT override -variant. Forcing it to a constant 32
+// made every TUIFollowControl report "Follow" regardless of the real account
+// relationship, which hid the Follow button on every tweet (NeoFreeBird#2).
+// The setVariant: remap above already converts Subscribe (1) -> Follow (32).
 
 %end
 
@@ -6262,13 +6259,24 @@ static BOOL BHPillLabelOverrideEnabled(void) {
     return [defaults boolForKey:@"refresh_pill_label"];
 }
 
+// Only the "new posts/Tweets" refresh pill should be relabelled. TFNPillControl
+// is used for other pills too ("Back to top", counts, …); the old code forced
+// every pill's text to "Tweeted" and corrupted their reads. Gate on the pill's
+// own text mentioning posts/tweets.
+static BOOL BHPillTextIsNewContent(id text) {
+    if (![text isKindOfClass:[NSString class]]) return NO;
+    NSString *s = [(NSString *)text lowercaseString];
+    return [s containsString:@"post"] || [s containsString:@"tweet"];
+}
+
 // MARK: Change Pill text, controlled by "refresh_pill_label"
 %hook TFNPillControl
 
 - (id)text {
-    if (!BHPillLabelOverrideEnabled()) {
-        // Setting is off, keep original behavior
-        return %orig;
+    id origText = %orig;
+    if (!BHPillLabelOverrideEnabled() || !BHPillTextIsNewContent(origText)) {
+        // Setting off, or not the new-content pill: keep original behavior
+        return origText;
     }
 
     NSString *localizedText = [[BHTBundle sharedBundle] localizedStringForKey:@"REFRESH_PILL_TEXT"];
@@ -6277,8 +6285,8 @@ static BOOL BHPillLabelOverrideEnabled(void) {
 }
 
 - (void)setText:(id)arg1 {
-    if (!BHPillLabelOverrideEnabled()) {
-        // Setting is off, pass through original argument
+    if (!BHPillLabelOverrideEnabled() || !BHPillTextIsNewContent(arg1)) {
+        // Setting off, or not the new-content pill: pass through original argument
         return %orig(arg1);
     }