Fix: Bailout gas distributed to diluent-only cylinders#183
Merged
Conversation
When a diluent cylinder uses the same gas mix as a bailout cylinder, the bailout gas requirement was incorrectly spread across both. Bailout gas must only be distributed across cylinders eligible for bailout, excluding diluent-only cylinders.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 70.11% 70.07% -0.05%
==========================================
Files 145 145
Lines 8099 8100 +1
Branches 1031 1031
==========================================
- Hits 5679 5676 -3
- Misses 1908 1912 +4
Partials 512 512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a diluent cylinder uses the same gas mix as a bailout cylinder, the bailout gas requirement was incorrectly spread across both. Bailout gas must only be distributed across cylinders eligible for bailout, excluding diluent-only cylinders.