Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_alert_playback.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre enregistrement {{name}} sera diffusé à {{time}}, dans {{duration}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_alert_recurring.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre {{kind}} est programmé pour {{time}}, tous les {{repeat}}.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre {{name}} sera diffusé à {{time}}, tous les {{repeat}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_alert_recurring_script.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre {{name}} sera exécuté à {{time}}, tous les {{repeat}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_alert_script.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre script {{name}} sera exécuté à {{time}}, dans {{duration}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_alert_set.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre {{kind}} est programmé pour {{time}}, dans {{duration}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_cancel_alert.dialog

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more variations of this sentence somehow, because some of the words for {{kind}} are feminine, and some are masculine, and the linking article is also modified if it is followed by a vowel. I don't know how to handle that on the dialog side. It is an understandable sentence as it is now, written without the article, but it's not good conversational usage.
(Note that the {{kind}} in confirm_alert_set.dialog and some other sentences correct as it is now, because there isn't an article. )

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Annulation : {{name}} ({{kind}}).
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_cancel_all.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
D'accord, tout est annulé pour {{kind}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_dismiss_alert.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{{kind}} ignoré.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_snooze_alert.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{{name}} reporté de {{duration}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/confirm_timer_started.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minuterie de {{duration}}, démarrage maintenant.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/error_audio_reminder_too_far.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Je ne peux configurer des rappels audio que 24 heures à l'avance. Je vais créer un événement de calendrier à la place.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/error_no_duration.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Je n'ai pas entendu la durée, veuillez réessayer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more variations of this sentence somehow, because some of the words for {{kind}} are feminine, and some are masculine.

Masculine would be as we have it:
Vous n'avez aucun {{kind}} planifié.

Feminine would be like this, and it's only a single letter difference from aucun to aucune, but it does make a large difference to the pronounciation of the word so it's necessary to handle it.
Vous n'avez aucune {{kind}} planifié.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rien n'est planifié pour {{kind}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/error_no_time.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Je n'ai pas entendu l'heure pour votre {{kind}}. Veuillez réessayer.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/error_nothing_to_cancel.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Je n'ai pas trouvé d'alerte correspondante à annuler.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/expired_alert.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Votre {{name}} est terminé.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/expired_audio_alert_intro.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Vous avez un rappel audio.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/expired_reminder.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Voici votre rappel: {{name}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{{name}} - à {{time}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert_intro.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pour {{kind}}, voici la liste :
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert_missed_intro.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Voici ce que vous avez manqué :
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert_none_missed.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Vous n'avez manqué aucune alerte.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert_none_upcoming.dialog

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more variations of this sentence somehow, because some of the words for {{kind}} are feminine, and some are masculine.

Masculine would be as we have it:
Vous n'avez aucun {{kind}} à venir.
Feminine would be like this, and it's only a single letter difference from aucun to aucune, but it does make a large difference to the pronounciation of the word so it's necessary to handle it.
Vous n'avez aucune {{kind}} à venir.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed that changing the sentence structure was the easiest solution here. Here is the best option I can identify, even with AI help. It isn't a response a human would usually give, but it is grammatically correct and a reasonable sentence to clearly communicate to the user.

It means "Your {{kind}} aren't turned on / engaged." In written form alarms would still need an extra 'e' but that doesn't affect pronunciation so this works fine for a voice system.

Vos {{kind}} ne sont pas enclenchés.

We can't use many better options because there is one more issue, which is that the article merges with the noun if the noun starts with a vowel. So it's "de rappels" and "de minuteurs" but "d'alarmes". So the best sentences which avoid gendered words can't be used because they have that variation in the article. Unfortunately we can't just shift to plural "des" like we would in English, because in French the negative forms of the sentence aren't allowed to be plural so they have to return to "de". So I think the above is our best choice.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rien n'est enclenché pour {{kind}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/list_alert_repeating.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{{name}} - tous les {{repeat}} à {{time}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/next_alert_named.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pour {{kind}}, {{name}} est prévu à {{time}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/next_alert_unnamed.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pour {{kind}}, prochain rendez-vous à {{time}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/quiet_hours_end.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Désactivation des heures calmes.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/quiet_hours_start.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Activation des heures calmes. Je ne vous notifierai d'aucune alerte jusqu'à ce que vous mettiez fin aux heures calmes.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/timer_status.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Il reste {{duration}} à {{timer}}.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/timer_status_none_active.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Il n'y a aucune minuterie active.
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_alarm.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
alarme
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_alert.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
alerte
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_day.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
jour
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_reminder.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
rappel
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_timer.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
minuterie
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
du lundi au vendredi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_friday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
vendredi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_monday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lundi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_saturday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
samedi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_sunday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dimanche
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_thursday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
jeudi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_tuesday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
mardi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekday_wednesday.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
mercredi
1 change: 1 addition & 0 deletions locale/fr-fr/dialog/word_weekend.dialog
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
samedi et dimanche
2 changes: 2 additions & 0 deletions locale/fr-fr/intent/list_alerts.intent
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
(quelles sont|dis-moi|liste) (mes|les|) (alertes|alarmes|minuteries|rappels|événements)
(y a-t-il|est-ce que j'ai)( des|)( prochaines| en attente|) (alertes|alarmes|minuteries|rappels|événements)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add spaces to the last set of word choices, which would make it into:

(y a-t-il|est-ce que j'ai)( des|)( prochaines| en attente|) ( alertes| alarmes| minuteries| rappels| événements)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a leading space already between the preceding word and the final word in the intent here attente|) (

4 changes: 4 additions & 0 deletions locale/fr-fr/intent/quiet_hours_end.intent

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine lines 2 and 3 and remove the null option from the first phrase, it's necessary to have it:

(est-ce que j'ai|ai-je)( manqué quelque chose| raté quelque chose)

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
réveille-toi
(est-ce que j'ai|ai-je)( manqué quelque chose| raté quelque chose)
qu'est-ce que j'ai manqué
(terminer|arrêter|désactiver) les heures calmes
3 changes: 3 additions & 0 deletions locale/fr-fr/intent/quiet_hours_start.intent
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
(dors|mets-toi en veille)(( pour| jusqu'à) {end_condition}|)
(activer|commencer) les heures calmes(( pour| jusqu'à) {end_condition}|)
ne me dérange pas(( pour| jusqu'à) {end_condition}|)
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/alarm.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
alarme
alarmes
réveille-moi
2 changes: 2 additions & 0 deletions locale/fr-fr/vocab/alert.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
alerte
alertes
4 changes: 4 additions & 0 deletions locale/fr-fr/vocab/all.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
tous
toutes
à venir
en attente
11 changes: 11 additions & 0 deletions locale/fr-fr/vocab/articles.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
sur
dans
mon
ma
mes
pour
le
la
les
à
neon
5 changes: 5 additions & 0 deletions locale/fr-fr/vocab/cancel.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
annuler
supprimer
effacer
arrêter
enlever
9 changes: 9 additions & 0 deletions locale/fr-fr/vocab/dismiss.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
ignorer
compris
d'accord
annuler
silencieux
arrêter
silence
effacer
terminer
4 changes: 4 additions & 0 deletions locale/fr-fr/vocab/event.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
rendez-vous
événement
événements
rendez-vous
7 changes: 7 additions & 0 deletions locale/fr-fr/vocab/everyday.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
tous les jours
chaque jour
quotidiennement
chaque nuit
chaque matin
chaque après-midi
chaque soir
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/next.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
prochain
prochaine
suivant
6 changes: 6 additions & 0 deletions locale/fr-fr/vocab/playable.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
audio
lecture
enregistrement
enregistré
voix
diffusion
2 changes: 2 additions & 0 deletions locale/fr-fr/vocab/priority.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
priorité
niveau de priorité
7 changes: 7 additions & 0 deletions locale/fr-fr/vocab/query.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
quel
quelle
quand
dis-moi
montre-moi
montre

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "montre-moi" to this list

liste
2 changes: 2 additions & 0 deletions locale/fr-fr/vocab/remind_me.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rappelle-moi
dis-moi de
2 changes: 2 additions & 0 deletions locale/fr-fr/vocab/reminder.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rappel
rappels
4 changes: 4 additions & 0 deletions locale/fr-fr/vocab/repeat.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
chaque
tous les
répétition
répétant
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/script.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
script
fichier de compétence
fichier
6 changes: 6 additions & 0 deletions locale/fr-fr/vocab/set.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
définir
créer
ajouter
commencer
j'ai
programmer
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/snooze.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
reporter
attendre
pause
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/timer.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
minuterie
minuteries
chronomètre
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/timer_time_remaining.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
combien de temps reste-t-il
statut de la minuterie
combien de temps
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/until.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
jusqu'à
pendant les prochaines
jusqu'à ce que
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/weekdays.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
jour de semaine
jours de semaine
en semaine
3 changes: 3 additions & 0 deletions locale/fr-fr/vocab/weekends.voc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
week-end
week-ends
fin de semaine
2 changes: 1 addition & 1 deletion skill.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"pip_spec": "neon-skill-alerts",
"license": "BSD-3-Clause",
"author": "Neongecko",
"version": "3.0.1",
"version": "3.0.2a1",
"url": "https://github.com/NeonGeckoCom/skill-alerts",
"skill_id": "skill-alerts.neongeckocom=skill_alerts:AlertSkill",
"skillname": "skill-alerts",
Expand Down
1 change: 1 addition & 0 deletions test/test_resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
languages:
- "en-us"
- "uk-ua"
- "fr-fr"

# vocab is lowercase .voc file basenames
vocab:
Expand Down
Loading